Re: [Patch] regex bracket expression implementaion

2013-08-03 Thread Paolo Carlini
Hi, >What's the format I should use? An email? Comments in the code? A PDF >document? Or? All sorts of comments in the code are always welcome: blurbs at the beginning of each file explaining the main design choices, then smaller comments explaining tricky points, TODO or FIXME when appropria

Re: [Patch] regex bracket expression implementaion

2013-08-03 Thread Tim Shen
On Fri, Aug 2, 2013 at 9:33 PM, Paolo Carlini wrote: > If nobody has further comments over the next day or so, patch is Ok with me. Committed. // http://gcc.gnu.org/ml/gcc-cvs/2013-07/msg00826.html > PS: I think it would be nice if from to time you could provide a rough > estimate of the amount

Re: [Patch] regex bracket expression implementaion

2013-08-02 Thread Paolo Carlini
Hi, On 08/01/2013 04:59 PM, Tim Shen wrote: Fully tested under x86_64. (make bootstrap && make -k check). Next, I'll try to refactor _Grep_matcher using templates instead of virtual functions, to make implementing back-reference easier. If nobody has further comments over the next day or so, p

[Patch] regex bracket expression implementaion

2013-08-01 Thread Tim Shen
Fully tested under x86_64. (make bootstrap && make -k check). Next, I'll try to refactor _Grep_matcher using templates instead of virtual functions, to make implementing back-reference easier. Thanks! -- Tim Shen bracket.patch Description: Binary data changelog Description: Binary data