Re: [Patch] libgomp: Fix on_device_arch.c aux-file handling [PR99555]

2021-03-29 Thread Thomas Schwinge
Hi! On 2021-03-26T16:22:20+0100, Jakub Jelinek wrote: > On Fri, Mar 26, 2021 at 04:19:56PM +0100, Tobias Burnus wrote: >> On 26.03.21 15:46, Jakub Jelinek via Gcc-patches wrote: >> > On Fri, Mar 26, 2021 at 03:42:22PM +0100, Tobias Burnus wrote: >> > > How about the following patch? It moves the

Re: [Patch] libgomp: Fix on_device_arch.c aux-file handling [PR99555] (was: [WIP] Re: [PATCH] openmp: Fix intermittent hanging of task-detach-6 libgomp tests [PR98738])

2021-03-26 Thread Jakub Jelinek via Gcc-patches
On Fri, Mar 26, 2021 at 04:19:56PM +0100, Tobias Burnus wrote: > Hi Jakub, > > great suggestion – I did now as proposed. > > On 26.03.21 15:46, Jakub Jelinek via Gcc-patches wrote: > > On Fri, Mar 26, 2021 at 03:42:22PM +0100, Tobias Burnus wrote: > > > How about the following patch? It moves the

Re: [Patch] libgomp: Fix on_device_arch.c aux-file handling [PR99555] (was: [WIP] Re: [PATCH] openmp: Fix intermittent hanging of task-detach-6 libgomp tests [PR98738])

2021-03-26 Thread Tobias Burnus
Hi Jakub, great suggestion – I did now as proposed. On 26.03.21 15:46, Jakub Jelinek via Gcc-patches wrote: On Fri, Mar 26, 2021 at 03:42:22PM +0100, Tobias Burnus wrote: How about the following patch? It moves the aux function to libgomp.c-c++-common/on_device_arch.c and #includes it in the

Re: [Patch] libgomp: Fix on_device_arch.c aux-file handling [PR99555] (was: [WIP] Re: [PATCH] openmp: Fix intermittent hanging of task-detach-6 libgomp tests [PR98738])

2021-03-26 Thread Jakub Jelinek via Gcc-patches
On Fri, Mar 26, 2021 at 03:42:22PM +0100, Tobias Burnus wrote: > How about the following patch? It moves the aux function to > libgomp.c-c++-common/on_device_arch.c > and #includes it in the new wrapper files > libgomp.{c,fortran}/on_device_arch.c. > (Based on the observation that #include with r

[Patch] libgomp: Fix on_device_arch.c aux-file handling [PR99555] (was: [WIP] Re: [PATCH] openmp: Fix intermittent hanging of task-detach-6 libgomp tests [PR98738])

2021-03-26 Thread Tobias Burnus
Hi Thomas, hi all, your commit causes compile fails: cc1: fatal error: ../lib/on_device_arch.c: No such file or directory FAIL: libgomp.c/../libgomp.c-c++-common/task-detach-6.c (test for excess errors) FAIL: libgomp.c/pr99555-1.c (test for excess errors) FAIL: libgomp.fortran/task-detach-6.f90