Re: [Patch] libgomp/target.c: Minor cleanup

2020-09-10 Thread Tobias Burnus
On 9/10/20 11:22 AM, Jakub Jelinek wrote: But it is not mapnum > 0 here but mapnum >1 Error: need more coffee (well, tea) Thanks for both the reasoning and catching this oversight of mine. Tobias - Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany

Re: [Patch] libgomp/target.c: Minor cleanup

2020-09-10 Thread Jakub Jelinek via Gcc-patches
On Thu, Sep 10, 2020 at 11:17:34AM +0200, Tobias Burnus wrote: > Hi Jakub, hello all, > > when looking at target.c, I stumbled over that code: > size_t mapnum → unsigned > if (mapnum == 0) > ... > return; > > if (mapnum > 0 || ) > ... But it is not mapnum > 0 here but mapn

[Patch] libgomp/target.c: Minor cleanup

2020-09-10 Thread Tobias Burnus
Hi Jakub, hello all, when looking at target.c, I stumbled over that code: size_t mapnum → unsigned if (mapnum == 0) ... return; if (mapnum > 0 || ) ... I fail to see how the latter condition can ever become false; hence, I removed the "if" and used the if-body uncondition