-- Tim,
while you work on these improvements, I think it would nice to also
commit, when appropriate, testcases which came with bug reports which we
closed as duplicates of the "std::regex is not implemented yet" report.
I'm not referring to this specific commit, just a general comment.
Than
On Mon, Jul 22, 2013 at 1:48 AM, Jonathan Wakely wrote:
> OK. The rest of the patch is fine - would you like me to commit it for
> you, with those fixes?
I can commit on my own. I've already been a write-after-approval.
Thank you again for reviewing!
--
Tim Shen
On 18 July 2013 11:06, Tim Shen wrote:
>
> These will be fixed when commit to SVN.
OK. The rest of the patch is fine - would you like me to commit it for
you, with those fixes?
On Wed, Jul 17, 2013 at 7:06 PM, Jonathan Wakely wrote:
> The changelog has a typo, _M__search_from_first has two underscores.
>
> The testcase dg-options should use -std=gnu++11 not -std=c++0x. Is
> the testcase based on an existing file? If not the copyright year
> should just be 2013.
These w
On 17 July 2013 11:26, Tim Shen wrote:
> A simple enumerating-first-position approach.
Thanks for the new patch. A couple of quick comments before I review
it properly:
The changelog has a typo, _M__search_from_first has two underscores.
The testcase dg-options should use -std=gnu++11 not -std=
A simple enumerating-first-position approach.
--
Tim Shen
regex_search.patch
Description: Binary data
