Re: [Patch] PR 65315 - Fix alignment of local variables

2015-03-05 Thread Steve Ellcey
On Thu, 2015-03-05 at 09:36 +0100, Richard Biener wrote: > > > > I have verified the fix on the MIPS test case in PR 65315 and am doing a > > regression test now. OK to checkin if there are no regressions? > > It looks like large_align vars are dynamically allocated and thus they > should be sor

Re: [Patch] PR 65315 - Fix alignment of local variables

2015-03-05 Thread Jeff Law
On 03/04/15 12:50, Steve Ellcey wrote: While examining some MIPS code I noticed that GCC did not seem to be fully honoring the aligned attribute on some local variables. I submitted PR middle-end/65315 to record the bug and I think I now understand it and have a fix. The problem was that expan

Re: [Patch] PR 65315 - Fix alignment of local variables

2015-03-05 Thread Richard Biener
On Wed, Mar 4, 2015 at 8:50 PM, Steve Ellcey wrote: > While examining some MIPS code I noticed that GCC did not seem to be > fully honoring the aligned attribute on some local variables. I submitted > PR middle-end/65315 to record the bug and I think I now understand it and > have a fix. The pro

[Patch] PR 65315 - Fix alignment of local variables

2015-03-04 Thread Steve Ellcey
While examining some MIPS code I noticed that GCC did not seem to be fully honoring the aligned attribute on some local variables. I submitted PR middle-end/65315 to record the bug and I think I now understand it and have a fix. The problem was that expand_stack_vars seemed to think that the fir