nvptx: 'cuDeviceGetCount' failure is fatal (was: [Patch] OpenMP: Move omp requires checks to libgomp)

2024-03-07 Thread Thomas Schwinge
Hi! On 2022-06-08T05:56:02+0200, Tobias Burnus wrote: > [...] On the libgomp side: The devices which do not fulfill the requirements > are > now filtered out. [...] > --- a/libgomp/plugin/plugin-gcn.c > +++ b/libgomp/plugin/plugin-gcn.c > /* Return the number of GCN devices on the system. *

Re: Fix Intel MIC 'mkoffload' for OpenMP 'requires' (was: [Patch] OpenMP: Move omp requires checks to libgomp)

2022-07-07 Thread Thomas Schwinge
Hi Tobias! On 2022-07-06T15:30:57+0200, Tobias Burnus wrote: > On 06.07.22 14:38, Thomas Schwinge wrote: >> :-) Haha, that's actually *exactly* what I had implemented first! But >> then I realized that 'target offloading_enabled' is doing exactly that: >> check that offloading compilation is con

Re: Fix Intel MIC 'mkoffload' for OpenMP 'requires' (was: [Patch] OpenMP: Move omp requires checks to libgomp)

2022-07-06 Thread Tobias Burnus
Hi Thomas, hello all, On 06.07.22 13:04, Thomas Schwinge wrote: On 2022-06-08T05:56:02+0200, Tobias Burnus wrote: PS: I have not fully tested the intelmic version. ... Subject: [PATCH] Fix Intel MIC 'mkoffload' for OpenMP 'requires' ... This also means finally switching Intel MIC 'mkoffloa

Re: Define 'OMP_REQUIRES_[...]', 'GOMP_REQUIRES_[...]' in a single place (was: [Patch] OpenMP: Move omp requires checks to libgomp)

2022-07-06 Thread Tobias Burnus
Hi Thomas, On 06.07.22 12:30, Thomas Schwinge wrote: On 2022-06-08T05:56:02+0200, Tobias Burnus wrote: [..] To make things more failure proof, OK to push the attached "Define 'OMP_REQUIRES_[...]', 'GOMP_REQUIRES_[...]' in a single place"? I concur that it makes sense to avoid having multipl

Re: Fix Intel MIC 'mkoffload' for OpenMP 'requires' (was: [Patch] OpenMP: Move omp requires checks to libgomp)

2022-07-06 Thread Tobias Burnus
Hi Thomas, On 06.07.22 14:38, Thomas Schwinge wrote: :-) Haha, that's actually *exactly* what I had implemented first! But then I realized that 'target offloading_enabled' is doing exactly that: check that offloading compilation is configured -- not that "there is an offloading device available

Re: Fix Intel MIC 'mkoffload' for OpenMP 'requires' (was: [Patch] OpenMP: Move omp requires checks to libgomp)

2022-07-06 Thread Thomas Schwinge
Hi Tobias! On 2022-07-06T13:29:14+0200, Tobias Burnus wrote: > On 06.07.22 13:04, Thomas Schwinge wrote: >> On 2022-06-08T05:56:02+0200, Tobias Burnus wrote: >>> PS: I have not fully tested the intelmic version. >> As part of my standard testing, I'm reporting that it got completely >> broken.

Re: Fix Intel MIC 'mkoffload' for OpenMP 'requires' (was: [Patch] OpenMP: Move omp requires checks to libgomp)

2022-07-06 Thread Tobias Burnus
Hi Thomas, On 06.07.22 13:04, Thomas Schwinge wrote: On 2022-06-08T05:56:02+0200, Tobias Burnus wrote: PS: I have not fully tested the intelmic version. As part of my standard testing, I'm reporting that it got completely broken. ;'-) Interesting. Because intelmic-mkoffload.cc calls GOMP_o

Fix Intel MIC 'mkoffload' for OpenMP 'requires' (was: [Patch] OpenMP: Move omp requires checks to libgomp)

2022-07-06 Thread Thomas Schwinge
Hi! On 2022-06-08T05:56:02+0200, Tobias Burnus wrote: > This is based on Chung-Lin's patch at > https://gcc.gnu.org/pipermail/gcc-patches/2021-January/563393.html > PS: I have not fully tested the intelmic version. As part of my standard testing, I'm reporting that it got completely broken. ;

Define 'OMP_REQUIRES_[...]', 'GOMP_REQUIRES_[...]' in a single place (was: [Patch] OpenMP: Move omp requires checks to libgomp)

2022-07-06 Thread Thomas Schwinge
Hi! On 2022-06-08T05:56:02+0200, Tobias Burnus wrote: > This is based on Chung-Lin's patch at > https://gcc.gnu.org/pipermail/gcc-patches/2021-January/563393.html > --- a/include/gomp-constants.h > +++ b/include/gomp-constants.h > +/* Flag values for requires-directive features, must match cor

Re: [Patch] OpenMP: Move omp requires checks to libgomp

2022-06-09 Thread Jakub Jelinek via Gcc-patches
On Thu, Jun 09, 2022 at 02:46:34PM +0200, Tobias Burnus wrote: > On 09.06.22 13:40, Jakub Jelinek via Gcc-patches wrote: > > On Wed, Jun 08, 2022 at 05:56:02AM +0200, Tobias Burnus wrote: > > > + && lookup_attribute ("omp declare target", > > > + DECL_ATTRIBUTES

Re: [Patch] OpenMP: Move omp requires checks to libgomp

2022-06-09 Thread Tobias Burnus
On 09.06.22 13:40, Jakub Jelinek via Gcc-patches wrote: On Wed, Jun 08, 2022 at 05:56:02AM +0200, Tobias Burnus wrote: + && lookup_attribute ("omp declare target", + DECL_ATTRIBUTES (current_function_decl))) + omp_requires_mask + = (enum omp_req

Re: [Patch] OpenMP: Move omp requires checks to libgomp

2022-06-09 Thread Jakub Jelinek via Gcc-patches
On Wed, Jun 08, 2022 at 05:56:02AM +0200, Tobias Burnus wrote: > gcc/c/ChangeLog: > > * c-parser.cc (c_parser_declaration_or_fndef): Set > OMP_REQUIRES_TARGET_USED in omp_requires_mask if function has > "omp declare target" attribute. > (c_parser_omp_target_data): Set OMP_R

[Patch] OpenMP: Move omp requires checks to libgomp

2022-06-07 Thread Tobias Burnus
This is based on Chung-Lin's patch at https://gcc.gnu.org/pipermail/gcc-patches/2021-January/563393.html This is about code like: #pragma omp requires unified_shared_memory !$omp requires reverse_offload which before was rejected with a sorry during parsing and is now handled in libgomp (by