Re: *PING* – Re: [Patch] OpenMP: Fix tmp-var handling with tree-nested.c [PR93553]

2020-08-03 Thread Jakub Jelinek via Gcc-patches
On Mon, Aug 03, 2020 at 06:01:40PM +0200, Tobias Burnus wrote: > On 7/20/20 11:20 PM, Tobias Burnus wrote: > > On 7/20/20 9:12 PM, Jakub Jelinek wrote: > > > I don't like this global variable. > > > Can you please instead stick it into struct nesting_info and make > > > sure it is > > > cleared whe

*PING* – Re: [Patch] OpenMP: Fix tmp-var handling with tree-nested.c [PR93553]

2020-08-03 Thread Tobias Burnus
On 7/20/20 11:20 PM, Tobias Burnus wrote: On 7/20/20 9:12 PM, Jakub Jelinek wrote: I don't like this global variable. Can you please instead stick it into struct nesting_info and make sure it is cleared where it is allocated? Done. The existing code uses struct nesting_info *info = XCNEW (s

Re: [Patch] OpenMP: Fix tmp-var handling with tree-nested.c [PR93553]

2020-07-20 Thread Tobias Burnus
On 7/20/20 9:12 PM, Jakub Jelinek wrote: I don't like this global variable. Can you please instead stick it into struct nesting_info and make sure it is cleared where it is allocated? Done. The existing code uses struct nesting_info *info = XCNEW (struct nesting_info); in create_nesting_tree

Re: [Patch] OpenMP: Fix tmp-var handling with tree-nested.c [PR93553]

2020-07-20 Thread Jakub Jelinek via Gcc-patches
On Mon, Jul 20, 2020 at 08:35:56PM +0200, Tobias Burnus wrote: > gcc/ChangeLog: > > PR fortran/93553 > * tree-nested.c (omp_new_clauses): New global var. > (convert_nonlocal_reference_op): Add init_tmp_var/init_tmp_var > vars to it. > (convert_nonlocal_omp_clauses, co

[Patch] OpenMP: Fix tmp-var handling with tree-nested.c [PR93553]

2020-07-20 Thread Tobias Burnus
This is about a PARAM_DECL of a procedure whose internal/nested procedure uses this inside an omp parallel. This leads to the code: D.3940 = x; (*D.3940)[D.3924] = …; And the temporary variable "D.3940" introduced for the nesting was not recorded as DECL for OpenMP, leading to the ICE in scan_om