Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-05-31 Thread Tobias Burnus
On 29.05.21 10:03, Jakub Jelinek wrote: On Fri, May 28, 2021 at 12:59:20AM +0200, Tobias Burnus wrote: * gfortran.dg/gomp/depend-iterator-1.f90: New test. * gfortran.dg/gomp/depend-iterator-2.f90: New test. Something I've missed during the review but it shows up during testing: Now

Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-05-31 Thread Jakub Jelinek via Gcc-patches
On Mon, May 31, 2021 at 10:14:34AM +0200, Christophe Lyon wrote: > > Something I've missed during the review but it shows up during testing: > > > > > diff --git a/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90 > > > b/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90 > > > new file mode

Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-05-31 Thread Christophe Lyon via Gcc-patches
On Sat, 29 May 2021 at 10:03, Jakub Jelinek via Gcc-patches wrote: > > On Fri, May 28, 2021 at 12:59:20AM +0200, Tobias Burnus wrote: > > * gfortran.dg/gomp/depend-iterator-1.f90: New test. > > * gfortran.dg/gomp/depend-iterator-2.f90: New test. > > Something I've missed during the rev

Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-05-29 Thread Jakub Jelinek via Gcc-patches
On Fri, May 28, 2021 at 12:59:20AM +0200, Tobias Burnus wrote: > * gfortran.dg/gomp/depend-iterator-1.f90: New test. > * gfortran.dg/gomp/depend-iterator-2.f90: New test. Something I've missed during the review but it shows up during testing: > diff --git a/gcc/testsuite/gfortran.dg/g

Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-05-27 Thread Tobias Burnus
On 27.05.21 21:58, Joseph Myers wrote: On Thu, 27 May 2021, Tobias Burnus wrote: @Joseph: I CC'ed you in case you have comments regarding c-parser.c's c_parser_check_balanced_raw_token_sequence Pilot error on my side – doing three things in parallel (fixing a patch, updating docs + attending

Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-05-27 Thread Jakub Jelinek via Gcc-patches
On Thu, May 27, 2021 at 07:58:03PM +, Joseph Myers wrote: > On Thu, 27 May 2021, Tobias Burnus wrote: > > > @Joseph: I CC'ed you in case you have comments regarding > > c-parser.c's c_parser_check_balanced_raw_token_sequence (comment update) > > and c_parser_check_tight_balanced_raw_token_sequ

Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-05-27 Thread Joseph Myers
On Thu, 27 May 2021, Tobias Burnus wrote: > @Joseph: I CC'ed you in case you have comments regarding > c-parser.c's c_parser_check_balanced_raw_token_sequence (comment update) > and c_parser_check_tight_balanced_raw_token_sequence (new); the latter > is essentially cp_parser_skip_balanced_tokens w

Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-05-27 Thread Jakub Jelinek via Gcc-patches
On Thu, May 27, 2021 at 08:30:33PM +0200, Tobias Burnus wrote: > + if (c_parser_next_token_is (parser, CPP_NAME)) > +{ > + const char *p = IDENTIFIER_POINTER (c_parser_peek_token > (parser)->value); > + bool parse_iter = (strcmp ("iterator", p) == 0); > + if (parse_iter) I'd a

Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-05-27 Thread Tobias Burnus
@Joseph: I CC'ed you in case you have comments regarding c-parser.c's c_parser_check_balanced_raw_token_sequence (comment update) and c_parser_check_tight_balanced_raw_token_sequence (new); the latter is essentially cp_parser_skip_balanced_tokens with slight adaptions. On 27.05.21 10:22, Jakub Je

Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-05-27 Thread Jakub Jelinek via Gcc-patches
On Wed, May 26, 2021 at 10:15:28PM +0200, Tobias Burnus wrote: > @@ -15508,6 +15511,57 @@ c_parser_omp_iterators (c_parser *parser) >return ret ? ret : error_mark_node; > } > > +/* OpenMP 5.0: > + affinity ( [aff-modifier :] variable-list ) > + aff-modifier: > + iterator ( iterators-

Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-05-26 Thread Tobias Burnus
Hi Jakub Updated patch attached – addressing your points: On 28.04.21 15:41, Jakub Jelinek wrote: On Tue, Apr 27, 2021 at 03:36:38PM +0200, Tobias Burnus wrote: [...] (a) This patch add the iterator support to the Fortran FE and adds support for it to the depend clause. (b) It also adds a con

Re: [Patch] Fortran/OpenMP: Fix var-list expr parsing with array/dt (was: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause)

2021-04-28 Thread Jakub Jelinek via Gcc-patches
On Wed, Apr 28, 2021 at 10:26:44PM +0200, Tobias Burnus wrote: > On 28.04.21 15:41, Jakub Jelinek wrote: > > > @@ -261,6 +263,7 @@ gfc_match_omp_variable_list (const char *str, > > > gfc_omp_namelist **list, > > > + gfc_gobble_whitespace (); > > >if ((allow_sections && gfc_peek_ascii_

[Patch] Fortran/OpenMP: Fix var-list expr parsing with array/dt (was: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause)

2021-04-28 Thread Tobias Burnus
On 28.04.21 15:41, Jakub Jelinek wrote: @@ -261,6 +263,7 @@ gfc_match_omp_variable_list (const char *str, gfc_omp_namelist **list, + gfc_gobble_whitespace (); if ((allow_sections && gfc_peek_ascii_char () == '(') || (allow_derived && gfc_peek_ascii_char () == '%') Is this

Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-04-28 Thread Jakub Jelinek via Gcc-patches
On Tue, Apr 27, 2021 at 03:36:38PM +0200, Tobias Burnus wrote: > OpenMP 5's iterator can be used for > - depend clause > - affinity clause > - mapping (unsupported and not touched) > > (a) This patch add the iterator support to the Fortran FE > and adds support for it to the depend clause. > > (b

[Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause

2021-04-27 Thread Tobias Burnus
OpenMP 5's iterator can be used for - depend clause - affinity clause - mapping (unsupported and not touched) (a) This patch add the iterator support to the Fortran FE and adds support for it to the depend clause. (b) It also adds a conforming stub implementation (parse & ignore in ME) for 'af