Re: [Patch] OpenMP/Fortran: Permit end-clause on directive

2022-11-27 Thread Tobias Burnus
Updated patch – taking the comments below into account – and the remark by Harald, second by Jakub. Namely: I have now split the pre-existing nowait-2.f90 into nowait-2.f90 (with only valid usage) and nowait-4.f90 (with the dg-error tests). In the previous version of the patch, nowait-4.f90 was a

Re: [Patch] OpenMP/Fortran: Permit end-clause on directive

2022-09-08 Thread Jakub Jelinek via Gcc-patches
On Thu, Sep 08, 2022 at 05:21:08PM +0200, Jakub Jelinek via Gcc-patches wrote: > Otherwise LGTM. Oh, and what Harald wrote, it might be better to split the nowait-4.f90 test into 2, one for all the valid nowait cases and one for the invalid ones, such that the first one can be compile tested all t

Re: [Patch] OpenMP/Fortran: Permit end-clause on directive

2022-09-08 Thread Jakub Jelinek via Gcc-patches
On Fri, Aug 26, 2022 at 08:21:26PM +0200, Tobias Burnus wrote: > I did run into some issues related to this; those turned out to be > unrelated, but I end ended up implementing this feature. > > Side remark: 'omp parallel workshare' seems to actually permit 'nowait' > now, but I guess that's an un

Re: [Patch] OpenMP/Fortran: Permit end-clause on directive

2022-08-29 Thread Harald Anlauf via Gcc-patches
Hi Tobias, this is not really a review, but: Am 26.08.22 um 20:21 schrieb Tobias Burnus: I did run into some issues related to this; those turned out to be unrelated, but I end ended up implementing this feature. Side remark: 'omp parallel workshare' seems to actually permit 'nowait' now, but

[Patch] OpenMP/Fortran: Permit end-clause on directive

2022-08-26 Thread Tobias Burnus
I did run into some issues related to this; those turned out to be unrelated, but I end ended up implementing this feature. Side remark: 'omp parallel workshare' seems to actually permit 'nowait' now, but I guess that's an unintended change due to the syntax-representation change. Hence, it is no