Re: [Patch] OpenMP/Fortran: 'target update' with DT components (was: [Patch] OpenMP/Fortran: 'target update' with strides + DT components)

2022-11-03 Thread Jakub Jelinek via Gcc-patches
On Thu, Nov 03, 2022 at 02:35:03PM +0100, Tobias Burnus wrote: > On 03.11.22 13:44, Jakub Jelinek wrote: > > [...] > > Otherwise LGTM, assuming it actually works correctly. > > > > I don't remember support for non-contiguous copying to/from devices > > being actually added, [...] And I think it is

[Patch] OpenMP/Fortran: 'target update' with DT components (was: [Patch] OpenMP/Fortran: 'target update' with strides + DT components)

2022-11-03 Thread Tobias Burnus
On 03.11.22 13:44, Jakub Jelinek wrote: [...] Otherwise LGTM, assuming it actually works correctly. I don't remember support for non-contiguous copying to/from devices being actually added, [...] And I think it is not ok to copy bytes that aren't requested to be copied. I have now removed that

Re: [Patch] OpenMP/Fortran: 'target update' with strides + DT components

2022-11-03 Thread Jakub Jelinek via Gcc-patches
On Mon, Oct 31, 2022 at 03:46:25PM +0100, Tobias Burnus wrote: > OpenMP/Fortran: 'target update' with strides + DT components > > OpenMP 5.0 permits to use arrays with strides and derived > type components for the list items to the 'from'/'to' clauses > of the 'target update' directive. > > gcc/f

[Patch] OpenMP/Fortran: 'target update' with strides + DT components

2022-10-31 Thread Tobias Burnus
I recently saw that gfortran does not support derived type components with 'target update', an OpenMP 5.0 feature. When adding it, I also found out that strides where not handled. There is probably some room of improvement about what to copy and what not, but copying too much should be fine. Bui