Re: [Patch] Internal functions for testsuite in regex

2013-10-06 Thread Tim Shen
On Sat, Oct 5, 2013 at 7:45 AM, Paolo Carlini wrote: > Patch looks great to me. If you don't get more comments over the next day or > so, please go ahead. Committed :) -- Tim Shen

Re: [Patch] Internal functions for testsuite in regex

2013-10-05 Thread Paolo Carlini
Hi, Tim Shen ha scritto: >Some are changed to size_t, some to long; some harmless ones are left. > >I'll do a bootstrap & full test before committing. Patch looks great to me. If you don't get more comments over the next day or so, please go ahead. Thanks! Paolo

Re: [Patch] Internal functions for testsuite in regex

2013-10-05 Thread Paolo Carlini
On 10/05/2013 03:58 AM, Tim Shen wrote: On Fri, Oct 4, 2013 at 12:30 PM, Paolo Carlini wrote: A completely different option, which I also like a lot in fact, would be putting the new *_testsuite functions inside the already existing testsuite/util/testsuite/regex.h. There you would use namespac

Re: [Patch] Internal functions for testsuite in regex

2013-10-04 Thread Paolo Carlini
.. a final one: if you don't like all those *_debug functions around, both in rehex.h and regex.tcc, you could move all of them to a new header matching the new naming scheme, like regex_debug.h. For the time being I would recommend putting it in bits/, installing it, including it from , exactl

Re: [Patch] Internal functions for testsuite in regex

2013-10-04 Thread Paolo Carlini
On 10/04/2013 06:04 PM, Paolo Carlini wrote: In particular, the new *_testsuite functions, isn't immediately clear in what they differ from the non-_testsuite variants. In any case we should figure out a better name, maybe even *_internal, if we can't find anything more accurate, but it should

Re: [Patch] Internal functions for testsuite in regex

2013-10-04 Thread Paolo Carlini
Hi, On 10/04/2013 04:13 PM, Tim Shen wrote: This is based on disscusions here(http://gcc.gnu.org/ml/libstdc++/2013-10/msg00034.html) And it successfully find a bug in regex_executor.tcc :) Booted and tested under -m32, -m64 and debug before the change in regex_executor.tcc; -m32 and -m64 only