Re: [Patch] Fix warnings in regex

2013-10-17 Thread Tim Shen
On Thu, Oct 17, 2013 at 3:58 PM, Paolo Carlini wrote: > Please explain in the ChangeLog *which* warnings. Committed with attached patch. Thanks! -- Tim Shen a.patch Description: Binary data

Re: [Patch] Fix warnings in regex

2013-10-17 Thread Paolo Carlini
On 10/17/2013 08:50 PM, Tim Shen wrote: ...to prevent potential bugs. By the way, I execute `g++ -E file.cc > prep.cc && sed -i 's|^#.*$||' prep.cc && g++ -Wall prep.cc 2> log` to get all warnings. Do we have a better way? Bootstraps and tested under -m64 and -m32. Please explain in the Change

Re: [Patch] Fix warnings in regex

2013-10-17 Thread Jakub Jelinek
On Thu, Oct 17, 2013 at 02:50:35PM -0400, Tim Shen wrote: > ...to prevent potential bugs. > > By the way, I execute `g++ -E file.cc > prep.cc && sed -i 's|^#.*$||' > prep.cc && g++ -Wall prep.cc 2> log` to get all warnings. Do we have a > better way? Sure, -Wsystem-headers -Wall. Jakub

Re: [Patch] Fix warnings in regex

2013-10-17 Thread Marc Glisse
On Thu, 17 Oct 2013, Tim Shen wrote: ...to prevent potential bugs. By the way, I execute `g++ -E file.cc > prep.cc && sed -i 's|^#.*$||' prep.cc && g++ -Wall prep.cc 2> log` to get all warnings. Do we have a better way? -Wsystem-headers ? (note also the -P flag) -- Marc Glisse

[Patch] Fix warnings in regex

2013-10-17 Thread Tim Shen
...to prevent potential bugs. By the way, I execute `g++ -E file.cc > prep.cc && sed -i 's|^#.*$||' prep.cc && g++ -Wall prep.cc 2> log` to get all warnings. Do we have a better way? Bootstraps and tested under -m64 and -m32. Thanks! -- Tim Shen a.patch Description: Binary data