Re: [Patch] Fix empty grouping problem in regex

2013-08-22 Thread Tim Shen
On Thu, Aug 22, 2013 at 9:08 AM, Tim Shen wrote: > Booted and tested with -m32, -m64 and -m64 debug-mode under x86_64 > GNU/Linux and committed(r201914). ...and here's the patch committed. -- Tim Shen emptygroup.patch Description: Binary data

Re: [Patch] Fix empty grouping problem in regex

2013-08-21 Thread Tim Shen
Change vector::at() call to vector::operator[](). Booted and tested with -m32, -m64 and -m64 debug-mode under x86_64 GNU/Linux and committed(r201914). -- Tim Shen

Re: [Patch] Fix empty grouping problem in regex

2013-08-19 Thread Mike Stump
On Aug 19, 2013, at 7:03 AM, Tim Shen wrote: > So should I later propose a single patch to make every 8 spaces to a > tab, or just make changes for all my committed files in this patch? One cannot merely replace 8 spaces with a tab, this doesn't work in general. If you expand all tabs in the fil

Re: [Patch] Fix empty grouping problem in regex

2013-08-19 Thread Paolo Carlini
Hi, On 08/19/2013 12:07 PM, Tim Shen wrote: +// 2013-08-08 Tim Shen +// +// Copyright (C) 2013 Free Software Foundation, Inc. Before committing, please adjust the date. Thanks, Paolo.

Re: [Patch] Fix empty grouping problem in regex

2013-08-19 Thread Tim Shen
Here's the correct version of changelog. -- Tim Shen changelog Description: Binary data

Re: [Patch] Fix empty grouping problem in regex

2013-08-19 Thread Tim Shen
On Mon, Aug 19, 2013 at 6:17 PM, Jakub Jelinek wrote: > Doesn't everything in between the last added line above and the first added > line below need reindenting by 2 spaces (plus of course transforming any 8 > consecutive spaces into tabs)? Thanks for correcting the indentation :) About tab vs

Re: [Patch] Fix empty grouping problem in regex

2013-08-19 Thread Jakub Jelinek
On Mon, Aug 19, 2013 at 06:07:10PM +0800, Tim Shen wrote: > Before this patch, it causes the executor into infinite loop. > > Tested under x86_64. I'll test -m32 and check-debug before committing. @@ -2371,8 +2372,10 @@ if (__re._M_automaton == nullptr) return false; for (au

[Patch] Fix empty grouping problem in regex

2013-08-19 Thread Tim Shen
Before this patch, it causes the executor into infinite loop. Tested under x86_64. I'll test -m32 and check-debug before committing. Thanks! -- Tim Shen changelog Description: Binary data emptygroup.patch Description: Binary data