Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-24 Thread Tim Shen
On Thu, Apr 24, 2014 at 12:38 PM, Jonathan Wakely wrote: > Great, thanks - OK for trunk. > > Assuming no problems on the trunk we might want to backport it for > 4.9.1 in a few weeks. > Committed. Thanks. -- Regards, Tim Shen

Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-24 Thread Jonathan Wakely
On 24/04/14 11:49 -0400, Tim Shen wrote: This testcase fails before the patch. Sorry for that. Great, thanks - OK for trunk. Assuming no problems on the trunk we might want to backport it for 4.9.1 in a few weeks.

Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-24 Thread Tim Shen
On Thu, Apr 24, 2014 at 6:56 AM, Jonathan Wakely wrote: > Unless I'm doing something wrong the new tests you added already give > the right results, do you have a testcase that fails with the current > code? This testcase fails before the patch. Sorry for that. -- Regards, Tim Shen commit f333

Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-24 Thread Jonathan Wakely
On 24 April 2014 04:47, Tim Shen wrote: >> Booted and tested with -m32 and -m64. > > I should give an explanation: > > When traversing a graph in _M_clone(), it should stop at a node with > id _M_end. However, if _M_end has other outgoing edge (_M_alt), the > edge should be concerned too. So this p

Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-23 Thread Tim Shen
On Wed, Apr 23, 2014 at 11:23 PM, Tim Shen wrote: > Booted and tested with -m32 and -m64. I should give an explanation: When traversing a graph in _M_clone(), it should stop at a node with id _M_end. However, if _M_end has other outgoing edge (_M_alt), the edge should be concerned too. So this p

[Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-23 Thread Tim Shen
Booted and tested with -m32 and -m64. Thanks! -- Regards, Tim Shen commit 96bcfcaf910630a1daa51332ab94c75843716f29 Author: tim Date: Wed Apr 23 00:56:21 2014 -0400 2014-04-24 Tim Shen * include/bits/regex_automaton.tcc (_StateSeq<>::_M_clone()): Do _M_alt before _