Re: [Patch] Add/modify regex comments

2014-03-15 Thread Tim Shen
On Sat, Mar 15, 2014 at 2:19 PM, Tim Shen wrote: > Booted, tested, and committed. Oops, forgot to attach the committed version. -- Regards, Tim Shen commit a4decc3a0f37bf24aaf50b7a0c7dba92c0ca45bb Author: tim Date: Fri Mar 14 14:50:12 2014 -0400 2014-03-15 Tim Shen * in

Re: [Patch] Add/modify regex comments

2014-03-15 Thread Tim Shen
On Fri, Mar 14, 2014 at 3:04 PM, Jonathan Wakely wrote: > If all the tests pass this is OK for trunk, thanks. Booted, tested, and committed. > N.B. the patch is fine but I don't think we usually say > > @brief Class FooBar. Does some Foo and some Bar. > > just > > @brief Does some Foo and so

Re: [Patch] Add/modify regex comments

2014-03-14 Thread Jonathan Wakely
On 14/03/14 14:55 -0400, Tim Shen wrote: Fix some inaccurate comments, especially the asymptotic complexity mark: o() => \Omega(). If all the tests pass this is OK for trunk, thanks. N.B. the patch is fine but I don't think we usually say @brief Class FooBar. Does some Foo and some Bar. ju

[Patch] Add/modify regex comments

2014-03-14 Thread Tim Shen
Fix some inaccurate comments, especially the asymptotic complexity mark: o() => \Omega(). Thanks! -- Regards, Tim Shen commit 7db473c494866d071087f3e7465e36cc96a918b1 Author: tim Date: Fri Mar 14 14:50:12 2014 -0400 2014-03-14 Tim Shen * include/bits/regex_compiler.h: Ad