[Patch] [gcn] Fix the output amdhsa.version (was: [Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c)

2025-02-07 Thread Tobias Burnus
Andrew Stubbs wrote: Otherwise, this patch seems fine (I have not reviewed the new magic numbers and settings.) As Andrew mentioned via chat, we also have to update the 'amdhsa.version'. Well, that's what the attached patch does. (I have no idea which tool / library relies on it, but it makes

Re: [Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c

2025-02-07 Thread Andrew Stubbs
eneric and generic-associated gfx*"   (email subject: "Re: [Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c";    this thread), https://gcc.gnu.org/pipermail/gcc-patches/2025- February/675259.html * * * This patch permits loading generic ISA code objects - by j

Re: [Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c

2025-02-07 Thread Andrew Stubbs
On 07/02/2025 00:25, Tobias Burnus wrote: After spending some time with the debugger, I am now convinced that ROCm 6.3.2 does not yet support generic. The amd-staging branch at https://github.com/ROCm/ROCR-Runtime/ support does, albeit only after the tag rocm-6.3.2. However, the released ROCm 6.3

Re: [Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c

2025-02-07 Thread Tobias Burnus
il subject: "Re: [Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c"; this thread), https://gcc.gnu.org/pipermail/gcc-patches/2025-February/675259.html * * * This patch permits loading generic ISA code objects - by just trying whether the runtime accepts it.

Re: [Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c

2025-02-06 Thread Tobias Burnus
After spending some time with the debugger, I am now convinced that ROCm 6.3.2 does not yet support generic. The amd-staging branch at https://github.com/ROCm/ROCR-Runtime/ support does, albeit only after the tag rocm-6.3.2. However, the released ROCm 6.3.2 does not match that tagged commit as it

Re: [Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c

2025-02-06 Thread Tobias Burnus
Updated version; changes: * Fixed SRAMECC setting for gfx906 - should be ANY (as in GCC 14) not UNSUPPORTED. (Shows up as link error when compiling with '-g'.) * Fixed generic handling for gfx9* - copy'n'paste bug: gfx11-generic is clearly wrong. * Implemented autoconvert from -march=gfx to

Re: [Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c

2025-02-05 Thread Andrew Stubbs
On 05/02/2025 12:51, Tobias Burnus wrote: Hi Andrew, Andrew Stubbs wrote: On 05/02/2025 11:14, Tobias Burnus wrote: Therefore, the following GPUs are now supported in addition: gfx902, gfx904, gfx909, gfx1031, gfx1032, gfx1033, gfx1034, gfx1035, gfx1101, gfx1102, gfx1150, gfx1151, gfx1152, an

Re: [Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c

2025-02-05 Thread Richard Biener
On Wed, 5 Feb 2025, Tobias Burnus wrote: > Hi Andrew, > > Andrew Stubbs wrote: > > On 05/02/2025 11:14, Tobias Burnus wrote: > >> Therefore, the following GPUs are now supported in addition: gfx902, > >> gfx904, gfx909, gfx1031, gfx1032, gfx1033, gfx1034, gfx1035, gfx1101, > >> gfx1102, gfx1150,

Re: [Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c

2025-02-05 Thread Tobias Burnus
Hi Andrew, Andrew Stubbs wrote: On 05/02/2025 11:14, Tobias Burnus wrote: Therefore, the following GPUs are now supported in addition: gfx902, gfx904, gfx909, gfx1031, gfx1032, gfx1033, gfx1034, gfx1035, gfx1101, gfx1102, gfx1150, gfx1151, gfx1152, and gfx1153. However, the multilib config ha

Re: [Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c

2025-02-05 Thread Andrew Stubbs
On 05/02/2025 11:14, Tobias Burnus wrote: The number of AMD GPUs is huge - and, unfortunately, every GPU device is potentially slightly different, requiring different code generation either in some dusty corner case or for standard code. As for several GPUs identical code can run (either all or

[Patch] [GCN] Handle generic ISA names in libgomp's plugin-gcn.c

2025-02-05 Thread Tobias Burnus
The number of AMD GPUs is huge - and, unfortunately, every GPU device is potentially slightly different, requiring different code generation either in some dusty corner case or for standard code. As for several GPUs identical code can run (either all or when disabling some features), AMD introduc