Re: [Patch][Demangler] Fix for complex values

2019-11-16 Thread Jeff Law
On 10/29/19 10:26 AM, Miguel Saldivar wrote: > There seems to be a small issue with the commit, somehow "float _Complex" > turned into "Complex" > within "demangle-expected", so the test now fails. Attached will be a fix > for it. Thank you for committing > the fix though. patch is complaining that

Re: [Patch][Demangler] Fix for complex values

2019-10-29 Thread Miguel Saldivar
There seems to be a small issue with the commit, somehow "float _Complex" turned into "Complex" within "demangle-expected", so the test now fails. Attached will be a fix for it. Thank you for committing the fix though. Miguel >From 7eb6afb42ff1ce1c22f0fce167c3fb593d316abb Mon Sep 17 00:00:00 2001

Re: [Patch][Demangler] Fix for complex values

2019-10-28 Thread Jeff Law
On 10/19/19 10:35 PM, Ian Lance Taylor wrote: > On Sat, Oct 19, 2019 at 9:11 PM Miguel Saldivar > wrote: >> >> Updated patch that uses `_Complex` and `_Imaginary` >> >> Thanks, >> Miguel Saldivar >> >> From 742b37c88bea0118046ac359cabe5f250d69ee30 Mon Sep 17 00:00:00 2001 >> From: Miguel Saldivar

Re: [Patch][Demangler] Fix for complex values

2019-10-19 Thread Ian Lance Taylor
On Sat, Oct 19, 2019 at 9:11 PM Miguel Saldivar wrote: > > Updated patch that uses `_Complex` and `_Imaginary` > > Thanks, > Miguel Saldivar > > From 742b37c88bea0118046ac359cabe5f250d69ee30 Mon Sep 17 00:00:00 2001 > From: Miguel Saldivar > Date: Sat, 19 Oct 2019 21:06:07 -0700 > Subject: [PATCH

Re: [Patch][Demangler] Fix for complex values

2019-10-19 Thread Miguel Saldivar
Updated patch that uses `_Complex` and `_Imaginary` Thanks, Miguel Saldivar >From 742b37c88bea0118046ac359cabe5f250d69ee30 Mon Sep 17 00:00:00 2001 From: Miguel Saldivar Date: Sat, 19 Oct 2019 21:06:07 -0700 Subject: [PATCH] Fix for complex and imaginary values gcc/libiberty/ * cp-demangle.c (d

Re: [Patch][Demangler] Fix for complex values

2019-10-18 Thread Miguel Saldivar
The only reason I wanted `float complex` was for interoperability between the two other demanglers. Although the go demangler does use `_Complex` and `_Imaginary`, so I guess it's sort of split. But I agree, `_Complex` and `_Imaginary` is probably the better option. Thanks, Miguel Saldivar On Fr

Re: [Patch][Demangler] Fix for complex values

2019-10-18 Thread Ian Lance Taylor via gcc-patches
On Thu, Oct 17, 2019 at 10:20 PM Miguel Saldivar wrote: > > This is a small fix for Bug 67299, where symbol: `Z1fCf` which would become > `f(float complex)` instead of `f(floatcomplex )`. > I thought this would be the preferred way of printing, because both > `llvm-cxxfilt` and `cpp_filt` both pri

[Patch][Demangler] Fix for complex values

2019-10-17 Thread Miguel Saldivar
This is a small fix for Bug 67299, where symbol: `Z1fCf` which would become `f(float complex)` instead of `f(floatcomplex )`. I thought this would be the preferred way of printing, because both `llvm-cxxfilt` and `cpp_filt` both print the the mangled name in this fashion. Thanks, Miguel Saldivar