Re: [Patch][Aarch64] Refactor comments in aarch64_print_operand

2017-07-14 Thread James Greenhalgh
On Fri, Jul 14, 2017 at 10:11:51AM +0100, Jackson Woodruff wrote: > Hi James, > > I have addressed the issues below. > > OK for trunk? This looks good to me, thanks for the patch. I've committed this to trunk on your behalf as revision 250202. Thanks, James

Re: [Patch][Aarch64] Refactor comments in aarch64_print_operand

2017-07-14 Thread Jackson Woodruff
Hi James, I have addressed the issues below. OK for trunk? Jackson On 07/13/2017 05:14 PM, James Greenhalgh wrote: On Thu, Jul 13, 2017 at 04:35:55PM +0100, Jackson Woodruff wrote: Hi James, I've addressed the issues discussed below. OK for trunk? I one last comment, otherwise, this looks

Re: [Patch][Aarch64] Refactor comments in aarch64_print_operand

2017-07-13 Thread James Greenhalgh
On Thu, Jul 13, 2017 at 04:35:55PM +0100, Jackson Woodruff wrote: > Hi James, > > I've addressed the issues discussed below. > > OK for trunk? I one last comment, otherwise, this looks good: > +/* Print operand X to file F in a target specific manner according to CODE. > + The acceptable form

Re: [Patch][Aarch64] Refactor comments in aarch64_print_operand

2017-07-13 Thread Jackson Woodruff
Hi James, I've addressed the issues discussed below. OK for trunk? Jackson On 07/13/2017 10:03 AM, James Greenhalgh wrote: On Tue, Jul 11, 2017 at 05:29:11PM +0100, Jackson Woodruff wrote: Hi all, This patch refactors comments in config/aarch64/aarch64.c aarch64_print_operand to provide a t

Re: [Patch][Aarch64] Refactor comments in aarch64_print_operand

2017-07-13 Thread James Greenhalgh
On Tue, Jul 11, 2017 at 05:29:11PM +0100, Jackson Woodruff wrote: > Hi all, > > This patch refactors comments in config/aarch64/aarch64.c > aarch64_print_operand > to provide a table of aarch64 specific formating options. > > I've tested the patch with a bootstrap and testsuite run on aarch64. >

[Patch][Aarch64] Refactor comments in aarch64_print_operand

2017-07-11 Thread Jackson Woodruff
Hi all, This patch refactors comments in config/aarch64/aarch64.c aarch64_print_operand to provide a table of aarch64 specific formating options. I've tested the patch with a bootstrap and testsuite run on aarch64. OK for trunk? Changelog: gcc/ 2017-07-04 Jackson Woodruff * config