Re: [Patch: RL78] Add support for 64-bit doubles

> The RX toolchain has a similar patch where the option is "doubles" > while the folder name is "double". There's no reason for one toolchain to be consistent with another, though. > Would it be ok to revert this line from "64-bit-doubles" to "64-bit-double" > as this? > +MULTILIB_DIRNAMES =

RE: [Patch: RL78] Add support for 64-bit doubles

Hi DJ, >> I assume this should be "doubles" not "double" though... I had made this change as suggested, however we had some issue while integrating the tools with our eclipse plug-ins. The RX toolchain has a similar patch where the option is "doubles" while the folder name is "double". Would it

RE: [Patch: RL78] Add support for 64-bit doubles

Hi DJ, > This is OK. Thanks! Do you need someone to commit it for you? Thanks, I can commit these changes. >> +MULTILIB_DIRNAMES = g10 64-bit-double > I assume this should be "doubles" not "double" though... Yes, will make that change and commit it. Best Regards, Kaushik

Re: [Patch: RL78] Add support for 64-bit doubles

This is OK. Thanks! Do you need someone to commit it for you? > +MULTILIB_OPTIONS= mg10 m64bit-doubles > +MULTILIB_DIRNAMES = g10 64-bit-double I assume this should be "doubles" not "double" though...

RE: [Patch: RL78] Add support for 64-bit doubles

Hi DJ, Please find below an updated patch which also adds the texi part. My earlier patch which addressed your comments is below, https://gcc.gnu.org/ml/gcc-patches/2014-05/msg01076.html The newlib and binutils part of this patch have been reviewed and committed: https://sourceware.org/ml/newlib/2

RE: [Patch: RL78] Add support for 64-bit doubles

Hi DJ, >> "long double" should always be 64 bits, which means that libgcc must >> always have DFmode helpers. Please find below a modified patch which sets the long double to 64 bits. This will use default settings for DFmode and libgcc long double types. I have also posted the binutils part of

Re: [Patch: RL78] Add support for 64-bit doubles

I think this part is wrong (and your mailer is dropping some whitespace). "long double" should always be 64 bits, which means that libgcc must always have DFmode helpers. #define LONG_DOUBLE_TYPE_SIZE64 /*DOUBLE_TYPE_SIZE*/ -#define LIBGCC2_HAS_DF_MODE1 +#ifdef __RL78_32BIT_DOUBLES__ +#define

RE: [Patch: RL78] Add support for 64-bit doubles

Hi DJ, Thanks for your review earlier. >> It looks OK, it's just the timing is bad. Please remind us after GCC is >> back in stage1. I am reposting this patch with GCC in stage 1. >> I would also like to see an explicit initialization for the variable to >> guarantee that the >> defau

Re: [Patch: RL78] Add support for 64-bit doubles

Sorry about the delay on this. As GCC is in pre-release and it would be bad for 4.9 to pass options that a released binutils doesn't support, I hesitate to approve this at this time. It looks OK, it's just the timing is bad. Please remind us after GCC is back in stage1. I would also like to se

[Patch: RL78] Add support for 64-bit doubles

Hi, Please find below a patch which adds support for 64-bit doubles to the RL78 target. This is largely based on the rx target port and uses similar option and multilibs. I will be posting the binutils and newlib part of this patch shortly. Kindly review the same and let me know if OK to commit.