RE: [Patch, testsuite] Skip case struct-layout-1 for targets using short enums.

2011-09-01 Thread Terry Guo
Hello Jakub, > The files are there to test the infrastructure. I'd say just try > 2011-09-01 Jakub Jelinek > > * gcc.dg/compat/struct-layout-1_test.h: Decrease bitfield size > to work even with -fshort-enums. > > --- gcc/testsuite/gcc.dg/compat/struct-layout-1_test.h2008-

Re: [Patch, testsuite] Skip case struct-layout-1 for targets using short enums.

2011-09-01 Thread Jakub Jelinek
On Thu, Sep 01, 2011 at 03:09:34PM +0800, Terry Guo wrote: > What you said is for compat/struct-layout-1.exp. What I said is for > compat/compat.exp. The case contains three files struct-layout-1_x.c, > struct-layout-1_y.c and struct-layout-1_main.c. All of them are independent > files and not gene

RE: [Patch, testsuite] Skip case struct-layout-1 for targets using short enums.

2011-09-01 Thread Terry Guo
Hello Jakub, > > On Thu, Sep 01, 2011 at 02:32:51PM +0800, Terry Guo wrote: > > FAIL: gcc.dg/compat/struct-layout-1 c_compat_x_tst.o compile > > FAIL: gcc.dg/compat/struct-layout-1 c_compat_y_tst.o compile > > UNRESOLVED: gcc.dg/compat/struct-layout-1 c_compat_x_tst.o- > c_compat_y_tst.o > > link

Re: [Patch, testsuite] Skip case struct-layout-1 for targets using short enums.

2011-08-31 Thread Jakub Jelinek
On Thu, Sep 01, 2011 at 02:32:51PM +0800, Terry Guo wrote: > FAIL: gcc.dg/compat/struct-layout-1 c_compat_x_tst.o compile > FAIL: gcc.dg/compat/struct-layout-1 c_compat_y_tst.o compile > UNRESOLVED: gcc.dg/compat/struct-layout-1 c_compat_x_tst.o-c_compat_y_tst.o > link > UNRESOLVED: gcc.dg/compat/

RE: [Patch, testsuite] Skip case struct-layout-1 for targets using short enums.

2011-08-31 Thread Terry Guo
Hello Jakub, > > On Thu, Sep 01, 2011 at 09:34:20AM +0800, Terry Guo wrote: > > Here is the patch, is it OK to commit? > > Definitely not. > struct-layout-1* already has support for short enums, see > http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110247 > So, if that doesn't work for you, you

Re: [Patch, testsuite] Skip case struct-layout-1 for targets using short enums.

2011-08-31 Thread Jakub Jelinek
On Thu, Sep 01, 2011 at 09:34:20AM +0800, Terry Guo wrote: > Here is the patch, is it OK to commit? Definitely not. struct-layout-1* already has support for short enums, see http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110247 So, if that doesn't work for you, you need to debug why. > 2011-08-

[Patch, testsuite] Skip case struct-layout-1 for targets using short enums.

2011-08-31 Thread Terry Guo
Hello, There are some bitfield definitions in this case, such as "enum E2 a:31". For most targets, the ENUM type size equals INT type so this definition is OK. But for some targets like arm_eabi, the default ENUM type size could be the smallest integer type that can contain all of its enumerated v