Re: [Patch, libstdc++/65420] Use constexpr variables as regex_constans flags

2015-03-27 Thread Tim Shen
On Fri, Mar 27, 2015 at 12:44 PM, Jonathan Wakely wrote: > I forgot to say that for a { dg-do compile } test you don't need a > 'test' variable and don't need to #include , Committed. -- Regards, Tim Shen commit a1b32eec28442e38b830078ce3a9c142b1072647 Author: Tim Shen Date: Fri Mar 27 20:3

Re: [Patch, libstdc++/65420] Use constexpr variables as regex_constans flags

2015-03-27 Thread Jonathan Wakely
On 15/03/15 23:27 -0700, Tim Shen wrote: +#include +#include + +// libstdc++/65420 +void +test01() +{ + bool test __attribute__((unused)) = true; I forgot to say that for a { dg-do compile } test you don't need a 'test' variable and don't need to #include ,

Re: [Patch, libstdc++/65420] Use constexpr variables as regex_constans flags

2015-03-26 Thread Jonathan Wakely
On 15/03/15 23:27 -0700, Tim Shen wrote: All it needs is something like: enum syntax_option_type : unsigned { }; constexpr syntax_option_type icase = ...; Acknowledged. Here's the simple version of it. OK for trunk, thanks.

Re: [Patch, libstdc++/65420] Use constexpr variables as regex_constans flags

2015-03-24 Thread Tim Shen
On Sun, Mar 15, 2015 at 11:27 PM, Tim Shen wrote: > Here's the simple version of it. Ping? -- Regards, Tim Shen

Re: [Patch, libstdc++/65420] Use constexpr variables as regex_constans flags

2015-03-15 Thread Tim Shen
On Sun, Mar 15, 2015 at 5:59 AM, Daniel Krügler wrote: (I switched to a less interesting but practical change, so all class stuff is gone. But I'd like to reply to your comments.) > Your implementation choice is an interesting approach. I believe that > a strict reading of the library specificat

Re: [Patch, libstdc++/65420] Use constexpr variables as regex_constans flags

2015-03-15 Thread Jonathan Wakely
On 15 March 2015 at 08:09, Tim Shen wrote: > Did a little bit refectoring on regex_constants, so that users won't > be polluted too much (they are not enum types anymore). I think this is overengineered and unnecessary. All it needs is something like: enum syntax_option_type : unsigned { }; cons

Re: [Patch, libstdc++/65420] Use constexpr variables as regex_constans flags

2015-03-15 Thread Daniel Krügler
2015-03-15 9:09 GMT+01:00 Tim Shen : > Did a little bit refectoring on regex_constants, so that users won't > be polluted too much (they are not enum types anymore). Your implementation choice is an interesting approach. I believe that a strict reading of the library specification does not allow t

[Patch, libstdc++/65420] Use constexpr variables as regex_constans flags

2015-03-15 Thread Tim Shen
Did a little bit refectoring on regex_constants, so that users won't be polluted too much (they are not enum types anymore). Bootstrapped and tested. Thanks! -- Regards, Tim Shen commit 5cd86b408ef0a9cba1a21a3018c797d9e245d158 Author: Tim Shen Date: Sat Mar 14 23:05:05 2015 -0700 P