Re: [Patch, libstdc++/64680] Conform the standard regex interface

2015-02-02 Thread Jonathan Wakely
On 01/02/15 00:18 -0800, Tim Shen wrote: On Wed, Jan 21, 2015 at 9:08 PM, Tim Shen wrote: Fixed and committed. I believe this one is also suitable for 4.9? I guess we don't have a 'code freeze' for 4.9 branch as we do for 5.0 late stage? Release branches are always in "regression fixes and

Re: [Patch, libstdc++/64680] Conform the standard regex interface

2015-02-01 Thread Tim Shen
On Wed, Jan 21, 2015 at 9:08 PM, Tim Shen wrote: > Fixed and committed. I believe this one is also suitable for 4.9? I guess we don't have a 'code freeze' for 4.9 branch as we do for 5.0 late stage? -- Regards, Tim Shen

Re: [Patch, libstdc++/64680] Conform the standard regex interface

2015-01-21 Thread Tim Shen
On Wed, Jan 21, 2015 at 3:51 AM, Jonathan Wakely wrote: > "Conform to ..." > >> standard interface. >> * testsuite/28_regex/basic_regex/assign/char/cstring.cc: New >> testcase. > > > As it's a tiny change it's OK for trunk with that tweak to the changelog. > > (Any more non-regress

Re: [Patch, libstdc++/64680] Conform the standard regex interface

2015-01-21 Thread Jonathan Wakely
On 20/01/15 20:05 -0800, Tim Shen wrote: On Tue, Jan 20, 2015 at 9:04 AM, Paolo Carlini wrote: When we end up doing this to save run time, let's at least add in a comment the PR #, like // PR libstdc++/64680 before test02(). Certainly. -- Regards, Tim Shen commit a150869847b7b02f57

Re: [Patch, libstdc++/64680] Conform the standard regex interface

2015-01-20 Thread Tim Shen
On Tue, Jan 20, 2015 at 8:05 PM, Tim Shen wrote: > Certainly. Removed dg-do compile flag, so that the testcase really works. -- Regards, Tim Shen commit fc08df0cbf03ad571414c5551b6eb014c27efe4a Author: timshen Date: Tue Jan 20 00:20:14 2015 -0800 PR libstdc++/64680 * includ

Re: [Patch, libstdc++/64680] Conform the standard regex interface

2015-01-20 Thread Tim Shen
On Tue, Jan 20, 2015 at 9:04 AM, Paolo Carlini wrote: > When we end up doing this to save run time, let's at least add in a comment > the PR #, like > > // PR libstdc++/64680 > > before test02(). Certainly. -- Regards, Tim Shen commit a150869847b7b02f57873fc18853b144a61c8880 Author: timshe

Re: [Patch, libstdc++/64680] Conform the standard regex interface

2015-01-20 Thread Paolo Carlini
Hi, On 01/20/2015 05:57 PM, Tim Shen wrote: +void test02() +{ + bool test __attribute__((unused)) = true; + + std::regex re("[[:alnum:]]", std::regex_constants::basic); + re = "\\w+"; +} When we end up doing this to save run time, let's at least add in a comment the PR #, like // PR li

[Patch, libstdc++/64680] Conform the standard regex interface

2015-01-20 Thread Tim Shen
Bootstrapped and tested. Thanks! -- Regards, Tim Shen commit 3f5cbfd3be15386c56d415cd15a04c3fc44ee8c0 Author: timshen Date: Tue Jan 20 00:20:14 2015 -0800 PR libstdc++/64680 * include/bits/regex.h (basic_regex<>::basic_regex, basic_regex<>::operator=, basic_regex<>::