Re: [Patch, libstdc++/64239] Use std::swap instead of swap in regex

2015-01-08 Thread Jonathan Wakely
On 08/01/15 11:44 -0800, Tim Shen wrote: On Wed, Jan 7, 2015 at 4:39 AM, Jonathan Wakely wrote: No blank line here in the ChangeLog. Done. This is swapping iterators, which can be user-defined types, so it should support finding a swap function by ADL, i.e. Done. Also, there should be a

Re: [Patch, libstdc++/64239] Use std::swap instead of swap in regex

2015-01-08 Thread Tim Shen
On Wed, Jan 7, 2015 at 4:39 AM, Jonathan Wakely wrote: > No blank line here in the ChangeLog. Done. > This is swapping iterators, which can be user-defined types, so it > should support finding a swap function by ADL, i.e. Done. > Also, there should be a new test, since apparently we don't hav

Re: [Patch, libstdc++/64239] Use std::swap instead of swap in regex

2015-01-07 Thread Jonathan Wakely
On 06/01/15 21:03 -0800, Tim Shen wrote: Bootstrapped and tested. It could be also patched to 4.9 branch. Thanks! -- Regards, Tim Shen commit dfe3a26759893849020a659b14fafe8b27e90dae Author: timshen Date: Tue Jan 6 19:30:27 2015 -0800 PR libstdc++/64239 No blank line here in

[Patch, libstdc++/64239] Use std::swap instead of swap in regex

2015-01-06 Thread Tim Shen
Bootstrapped and tested. It could be also patched to 4.9 branch. Thanks! -- Regards, Tim Shen commit dfe3a26759893849020a659b14fafe8b27e90dae Author: timshen Date: Tue Jan 6 19:30:27 2015 -0800 PR libstdc++/64239 * include/bits/regex.h (match_results<>::swap): Use std::