Re: [Patch, libstdc++/63775] Fix regex bracket expression parsing

2015-06-04 Thread Jonathan Wakely
On 01/06/15 20:51 -0700, Tim Shen wrote: On Tue, Nov 25, 2014 at 12:46 AM, Tim Shen wrote: On Wed, Nov 12, 2014 at 11:45 PM, Tim Shen wrote: Committed with comment fix and slight change on testcase (VERIFY(false) at end of the try block -- must throw). Is it possible to backport this pa

Re: [Patch, libstdc++/63775] Fix regex bracket expression parsing

2015-06-01 Thread Tim Shen
On Tue, Nov 25, 2014 at 12:46 AM, Tim Shen wrote: > On Wed, Nov 12, 2014 at 11:45 PM, Tim Shen wrote: >> Committed with comment fix and slight change on testcase >> (VERIFY(false) at end of the try block -- must throw). > > Is it possible to backport this patch to 4.9 branch? It's an importan

Re: [Patch, libstdc++/63775] Fix regex bracket expression parsing

2014-11-25 Thread Tim Shen
On Wed, Nov 12, 2014 at 11:45 PM, Tim Shen wrote: > Committed with comment fix and slight change on testcase > (VERIFY(false) at end of the try block -- must throw). Is it possible to backport this patch to 4.9 branch? It's an important fix, but I'm not sure if there's any binary compatibilit

Re: [Patch, libstdc++/63775] Fix regex bracket expression parsing

2014-11-12 Thread Tim Shen
On Mon, Nov 10, 2014 at 10:32 AM, Jonathan Wakely wrote: > OK for trunk with the small change above - thanks! Committed with comment fix and slight change on testcase (VERIFY(false) at end of the try block -- must throw). -- Regards, Tim Shen commit 63544c468fa784a354def7bc240b2cd93210f6d8

Re: [Patch, libstdc++/63775] Fix regex bracket expression parsing

2014-11-10 Thread Jonathan Wakely
On 09/11/14 10:17 -0800, Tim Shen wrote: __matcher._M_add_equivalence_class(_M_value); else if (_M_match_token(_ScannerT::_S_token_char_class_name)) __matcher._M_add_character_class(_M_value, false); - else if (_M_try_char()) // [a + // POSIX doesn't permit '-' as

[Patch, libstdc++/63775] Fix regex bracket expression parsing

2014-11-09 Thread Tim Shen
Bootstrapped and tested. Thanks! -- Regards, Tim Shen commit 1cb5f4e018e52d94e4902bd2424b8d5e75d917c2 Author: timshen Date: Sat Nov 8 18:19:56 2014 -0800 PR libstdc++/63775 * include/bits/regex_compiler.h (_Compiler<>::_M_expression_term, _BracketMatcher<>::_M_make_r