Re: [Patch, libfortran] Fix handling of temporary files

2012-05-04 Thread Janne Blomqvist
On Fri, May 4, 2012 at 12:49 PM, Tobias Burnus wrote: > Dear Janne, > > sorry for the really slow review. > > Janne Blomqvist wrote: >> the attached patch implements some fixes for handling STATUS="SCRATCH" files. > ... >> Currently, we check [...] but not the POSIX and GNU standard TMPDIR [...] >

Re: [Patch, libfortran] Fix handling of temporary files

2012-05-04 Thread Tobias Burnus
Dear Janne, sorry for the really slow review. Janne Blomqvist wrote: > the attached patch implements some fixes for handling STATUS="SCRATCH" files. ... > Currently, we check [...] but not the POSIX and GNU standard TMPDIR [...] > If the program is privileged, we shouldn't trust path style enviro

Re: [Patch, libfortran] Fix handling of temporary files

2012-05-02 Thread Janne Blomqvist
PING #2 On Thu, Apr 26, 2012 at 12:19 AM, Janne Blomqvist wrote: > PING! > > On Thu, Apr 19, 2012 at 01:18, Janne Blomqvist > wrote: >> Hi, >> >> the attached patch implements some fixes for handling STATUS="SCRATCH" files. >> >> - Currently, we check GFORTRAN_TMPDIR, TMP, and TEMP environment >

Re: [Patch, libfortran] Fix handling of temporary files

2012-04-25 Thread Janne Blomqvist
PING! On Thu, Apr 19, 2012 at 01:18, Janne Blomqvist wrote: > Hi, > > the attached patch implements some fixes for handling STATUS="SCRATCH" files. > > - Currently, we check GFORTRAN_TMPDIR, TMP, and TEMP environment > variables, but not the POSIX and GNU standard TMPDIR. As specifying a > tempor

Re: [Patch, libfortran] Fix handling of temporary files

2012-04-19 Thread Janne Blomqvist
On Thu, Apr 19, 2012 at 14:43, Janne Blomqvist wrote: > Also, I suspect getuid and friends are not actually part of the NSS > stuff. The uid/gid/euid/egid are maintained for each process by the > kernel, and NSS only handles translation to/from the numeric id's to > string values, IP address looku

Re: [Patch, libfortran] Fix handling of temporary files

2012-04-19 Thread Janne Blomqvist
On Thu, Apr 19, 2012 at 11:52, Manfred Schwarb wrote: > Am 19.04.2012 09:25, schrieb Janne Blomqvist: > >> On Thu, Apr 19, 2012 at 01:45, Manfred Schwarb  wrote: >>> >>> Hi Janne, >>> >>> - If the program is privileged, we shouldn't trust path style environment variables. The patch

Re: [Patch, libfortran] Fix handling of temporary files

2012-04-19 Thread Manfred Schwarb
Am 19.04.2012 09:25, schrieb Janne Blomqvist: On Thu, Apr 19, 2012 at 01:45, Manfred Schwarb wrote: Hi Janne, - If the program is privileged, we shouldn't trust path style environment variables. The patch fixes this for TMPDIR and also for the logic figuring out where addr2line is. I di

Re: [Patch, libfortran] Fix handling of temporary files

2012-04-19 Thread Janne Blomqvist
On Thu, Apr 19, 2012 at 01:45, Manfred Schwarb wrote: > Hi Janne, > > >> >> - If the program is privileged, we shouldn't trust path style >> environment variables. The patch fixes this for TMPDIR and also for >> the logic figuring out where addr2line is. > > > > I did not test it, but if I remembe

Re: [Patch, libfortran] Fix handling of temporary files

2012-04-18 Thread Manfred Schwarb
Hi Janne, - If the program is privileged, we shouldn't trust path style environment variables. The patch fixes this for TMPDIR and also for the logic figuring out where addr2line is. I did not test it, but if I remember right, the use of geteuid() and friends does prevent static compilation,

[Patch, libfortran] Fix handling of temporary files

2012-04-18 Thread Janne Blomqvist
Hi, the attached patch implements some fixes for handling STATUS="SCRATCH" files. - Currently, we check GFORTRAN_TMPDIR, TMP, and TEMP environment variables, but not the POSIX and GNU standard TMPDIR. As specifying a temporary directory depending on the compiler used to create an application does