Re: [Patch, fortran] Use memcmp for string comparisons a bit more

2013-03-30 Thread Thomas Koenig
Hi Tobias, Somehow the commas and parentheses look odd. Shouldn't that be, e.g., "or (for kind=4 strings) the ..."? I committed as rev 197261 and 197262, with a slightly better worded ChangeLog entry :-) The wording is now If the strings compared have constant and equal leng

Re: [Patch, fortran] Use memcmp for string comparisons a bit more

2013-03-29 Thread Tobias Burnus
Am 29.03.2013 21:53, schrieb Thomas Koenig: Am 29.03.2013 15:56, schrieb Tobias Burnus: Thus, how about using memcmp for kind=4 for == and /= only - and for kind=1 also for <, > etc.? OK, there is the updated patch. OK thanks for the patch! 2013-03-25 Thomas Koenig * trans-expr

[Patch, fortran] Use memcmp for string comparisons a bit more

2013-03-29 Thread Thomas Koenig
Am 29.03.2013 15:56, schrieb Tobias Burnus: Thus, how about using memcmp for kind=4 for == and /= only - and for kind=1 also for <, > etc.? OK, there is the updated patch. 2013-03-25 Thomas Koenig * trans-expr.c (build_memcmp_call): New function. (gfc_build_compare_string