Re: [Patch, fortran] PR83344 - Use of uninitialized memory with ASSOCIATE and strings

2018-02-19 Thread Paul Richard Thomas
Committed as revision 257827. > 1. The resolve.c part of the patch seems to have incorrect indentation? I can't see what you are referring to. I'll correct it if needs be > > 2. Instead of gfc_index_zero_node would it be better to use > build_zero_cst (gfc_charlen_type_node)? Or is the same

Re: [Patch, fortran] PR83344 - Use of uninitialized memory with ASSOCIATE and strings

2018-02-19 Thread Janne Blomqvist
On Mon, Feb 19, 2018 at 2:39 PM, Paul Richard Thomas wrote: > Hi Janne, > > Please find attached a revised version of the patch that fixes all the > issues that I know of. > > Regtests on FC27/x86_64 - OK for trunk? 1. The resolve.c part of the patch seems to have incorrect indentation? 2. Inste

Re: [Patch, fortran] PR83344 - Use of uninitialized memory with ASSOCIATE and strings

2018-02-19 Thread Paul Richard Thomas
Hi Janne, Please find attached a revised version of the patch that fixes all the issues that I know of. Regtests on FC27/x86_64 - OK for trunk? I have also attached a test of all the failing cases in PR83975. However, I believe that they are all included in other associate*.f*. Cheers Paul 20

Re: [Patch, fortran] PR83344 - Use of uninitialized memory with ASSOCIATE and strings

2018-02-18 Thread Paul Richard Thomas
Hi Janne and Thomas, 1) The patch is attached now - sorry! 2) The commented out part of associate_22.f90 is not yet fixed. I am working on it. 3) I will take a look at PR83975 tomorrow night. Paul On 18 February 2018 at 16:08, Janne Blomqvist wrote: > On Sun, Feb 18, 2018 at 5:48 PM, Paul Ri

Re: [Patch, fortran] PR83344 - Use of uninitialized memory with ASSOCIATE and strings

2018-02-18 Thread Janne Blomqvist
On Sun, Feb 18, 2018 at 5:48 PM, Paul Richard Thomas wrote: > Bootstraps and regtests on FC27/x86_64 - OK for trunk? Hi, thanks for looking into this! 1. The patch itself is missing... 2. Could you uncomment the commented out part of associate_22.f90 and check that the tree-original dump is se

[Patch, fortran] PR83344 - Use of uninitialized memory with ASSOCIATE and strings

2018-02-18 Thread Paul Richard Thomas
Bootstraps and regtests on FC27/x86_64 - OK for trunk? Paul 2018-02-18 Paul Thomas PR fortran/83344 * resolve.c (resolve_assoc_var): Character associate names that have no length expression that have variable targets and are not deferred length have assumed length. * trans