Re: [Patch, fortran] PR52846 - [F2008] Support submodules

2015-07-02 Thread Paul Richard Thomas
Dear All, Committed as revision 225354. Compared with the submitted version, I have added another test - submodule_7.f90. This is a slightly tweaked version of the example in the F2008 standard. In order to get it to compile, the error produced by the main program's interface block was suppressed

Re: [Patch, fortran] PR52846 - [F2008] Support submodules

2015-06-30 Thread FX
Hi Paul, I don’t feel confident enough in many parts of the code (including the module part) to formally review it, but from what I’ve read it seemed rather logical and well-commented. If it regtests fine, I think your plan (especially at the current GCC stage) of committing this week is sound.

Re: [Patch, fortran] PR52846 - [F2008] Support submodules

2015-06-30 Thread Paul Richard Thomas
Dear All, Please find attached the latest version of the submodule patch. You might note that the number of the patch has been incremented by two. The intermediate version went to Reinhold Bader and co for testing. The main improvements in this version are: (i) As reported by Reinhold, the interfa

Re: [Patch, fortran] PR52846 - [F2008] Support submodules

2015-06-25 Thread Paul Richard Thomas
Thomas [mailto:paul.richard.tho...@gmail.com] >> Gesendet: Donnerstag, 25. Juni 2015 17:16 >> An: fort...@gcc.gnu.org; gcc-patches >> Cc: Damian Rouson; Tobias Burnus; salvatore.filipp...@uniroma2.it; Bader, >> Reinhold >> Betreff: Re: [Patch, fortran] PR52846 - [F2008] Suppo

AW: [Patch, fortran] PR52846 - [F2008] Support submodules

2015-06-25 Thread Bader, Reinhold
t; Von: Paul Richard Thomas [mailto:paul.richard.tho...@gmail.com] > Gesendet: Donnerstag, 25. Juni 2015 17:16 > An: fort...@gcc.gnu.org; gcc-patches > Cc: Damian Rouson; Tobias Burnus; salvatore.filipp...@uniroma2.it; Bader, > Reinhold > Betreff: Re: [Patch, fortran] PR52846 - [F200

Re: [Patch, fortran] PR52846 - [F2008] Support submodules

2015-06-25 Thread Paul Richard Thomas
Dear All, Please find attached an updated version of the submodule patch. Reinhold Bader uncovered a couple of bugs, which have now been fixed: (i) IMPORT is no longer permitted in module_procedure interface bodies, as required by F2008(C1210). Instead, import occurs automatically; and (ii) The en

[Patch, fortran] PR52846 - [F2008] Support submodules

2015-06-22 Thread Paul Richard Thomas
Dear All, This patch enables submodule support in gfortran. Submodules are a feature of F2008 but are fully described in ISO/IEC TR 19767:2004(E). The patch has one significant non-conformance (that I know about, anyway!); whilst private derived type components are correctly dealt with, symbols w