Hi,
no, I lost patience with this. Attached is the last version of this patch I will
provide. I have changed some things to fix the issues needed for
allocate_with_source_3.f90 (now called allocate_with_source_8.f08) to run. The
fix implies that source=[type_constructor(...)] generate a zero-bound
Hello Andre,
comments below (out of order, sorry).
Le 29/05/2015 13:46, Andre Vehreschild a écrit :
> Hi Mikael,
>
> comments inline below:
>
> On Thu, 28 May 2015 20:06:57 +0200
> Mikael Morin wrote:
>
>> Le 28/05/2015 17:29, Andre Vehreschild a écrit :
>>> *** resolve_allocate_e
Hi Andre,
just a couple of remarks.
You are adding significant new code to an existing
test case, allocate_with_source_3.f90. As discussed
previously, it would be better to put the new code
into an extra test case.
The following test case segfaults with your patch
with an "invalid free":
modul
Hi Mikael,
comments inline below:
On Thu, 28 May 2015 20:06:57 +0200
Mikael Morin wrote:
> Le 28/05/2015 17:29, Andre Vehreschild a écrit :
> > *** resolve_allocate_expr (gfc_expr *e, gfc_
> > *** 7103,7112
> > --- 7103,7123
> > if (!ref2 || ref2->type != REF_ARRAY ||
Le 28/05/2015 17:29, Andre Vehreschild a écrit :
> *** resolve_allocate_expr (gfc_expr *e, gfc_
> *** 7103,7112
> --- 7103,7123
> if (!ref2 || ref2->type != REF_ARRAY || ref2->u.ar.type == AR_FULL
> || (dimension && ref2->u.ar.dimen == 0))
> {
> + /* F0
Hi Mikael,
thanks for the comments so far.
> I don't understand why one of your previous patches was factoring the
> source expression evaluation to a temporary in gfc_trans_allocate, and
> now with this patch you do the same thing in gfc_resolve_allocate, not
> reusing the part in gfc_trans_allo
Le 19/05/2015 12:26, Andre Vehreschild a écrit :
> Hi all,
>
> update based on latest 65548 (v5) patch and current trunk. Description and
> issue addressed unchanged (see cite below).
>
> Bootstrapped and regtested on x86_64-linux-gnu/f21.
>
> Any volunteers to review? The initial version dates
Hi,
the patch (65548) this one depends on is in trunk now.
Still bootstraps ok and regtests with the issue in
gfortran.dg/alloc_comp_constructor_1.f90 (which is addressed by the patch for
pr58586 already) on x86_64-linux-gnu/f21.
Ok for trunk?
- Andre
On Tue, 19 May 2015 12:26:02 +0200
Andre
Hi all,
update based on latest 65548 (v5) patch and current trunk. Description and
issue addressed unchanged (see cite below).
Bootstrapped and regtested on x86_64-linux-gnu/f21.
Any volunteers to review? The initial version dates back to March 30. 2015. Not
a single comment so far!
- Andre
