Re: [Patch, avr] Fix PR 71151

2016-06-23 Thread Mike Stump
On Jun 23, 2016, at 9:16 AM, Georg-Johann Lay wrote: > Maybe even check during configure whether an appropriate version of > Binutils is used? >> That would be nice, but is it ok to add target specific conditions to >> configure.ac? > > We already have avr-specific tests in gcc/configure

Re: [Patch, avr] Fix PR 71151

2016-06-23 Thread Georg-Johann Lay
Senthil Kumar Selvaraj schrieb: Georg-Johann Lay writes: Senthil Kumar Selvaraj schrieb: Senthil Kumar Selvaraj writes: Georg-Johann Lay writes: Senthil Kumar Selvaraj schrieb: Hi, [set JUMP_TABLES_IN_TEXT_SECTION to 1] I added tests that use linker relaxation and discovered a relaxat

Re: [Patch, avr] Fix PR 71151

2016-06-22 Thread Senthil Kumar Selvaraj
Georg-Johann Lay writes: > Senthil Kumar Selvaraj schrieb: >> Senthil Kumar Selvaraj writes: >> >>> Georg-Johann Lay writes: >>> Senthil Kumar Selvaraj schrieb: > Hi, > > [set JUMP_TABLES_IN_TEXT_SECTION to 1] >>> >>> I added tests that use linker relaxation and discovered a r

Re: [Patch, avr] Fix PR 71151

2016-06-22 Thread Georg-Johann Lay
Senthil Kumar Selvaraj schrieb: Senthil Kumar Selvaraj writes: Georg-Johann Lay writes: Senthil Kumar Selvaraj schrieb: Hi, [set JUMP_TABLES_IN_TEXT_SECTION to 1] I added tests that use linker relaxation and discovered a relaxation bug in binutils 2.26 (and later) that messes up symbol

Re: [Patch, avr] Fix PR 71151

2016-06-18 Thread Senthil Kumar Selvaraj
Georg-Johann Lay writes: > Senthil Kumar Selvaraj schrieb: >> Hi, >> >> This patch fixes PR 71151 by eliminating the >> TARGET_ASM_FUNCTION_RODATA_SECTION hook and setting >> JUMP_TABLES_IN_TEXT_SECTION to 1. >> >> As described in the bugzilla entry, this hook assumed it will get >> c

Re: [Patch, avr] Fix PR 71151

2016-06-17 Thread Georg-Johann Lay
Senthil Kumar Selvaraj schrieb: Hi, This patch fixes PR 71151 by eliminating the TARGET_ASM_FUNCTION_RODATA_SECTION hook and setting JUMP_TABLES_IN_TEXT_SECTION to 1. As described in the bugzilla entry, this hook assumed it will get called only for jumptable rodata for functions. This

Re: [Patch, avr] Fix PR 71151

2016-06-16 Thread Senthil Kumar Selvaraj
Denis Chertykov writes: > 2016-06-16 10:27 GMT+03:00 Senthil Kumar Selvaraj > : >> >> Senthil Kumar Selvaraj writes: >> >>> Georg-Johann Lay writes: >>> Senthil Kumar Selvaraj schrieb: > Hi, > > This patch fixes PR 71151 by eliminating the > TARGET_ASM_FUNCTION_RODATA_SEC

Re: [Patch, avr] Fix PR 71151

2016-06-16 Thread Denis Chertykov
2016-06-16 10:27 GMT+03:00 Senthil Kumar Selvaraj : > > Senthil Kumar Selvaraj writes: > >> Georg-Johann Lay writes: >> >>> Senthil Kumar Selvaraj schrieb: Hi, This patch fixes PR 71151 by eliminating the TARGET_ASM_FUNCTION_RODATA_SECTION hook and setting JUMP_TABLES

Re: [Patch, avr] Fix PR 71151

2016-06-16 Thread Senthil Kumar Selvaraj
Senthil Kumar Selvaraj writes: > Georg-Johann Lay writes: > >> Senthil Kumar Selvaraj schrieb: >>> Hi, >>> >>> This patch fixes PR 71151 by eliminating the >>> TARGET_ASM_FUNCTION_RODATA_SECTION hook and setting >>> JUMP_TABLES_IN_TEXT_SECTION to 1. >>> >>> As described in the bugzilla

Re: [Patch, avr] Fix PR 71151

2016-06-07 Thread Senthil Kumar Selvaraj
Georg-Johann Lay writes: > Senthil Kumar Selvaraj schrieb: >> Hi, >> >> This patch fixes PR 71151 by eliminating the >> TARGET_ASM_FUNCTION_RODATA_SECTION hook and setting >> JUMP_TABLES_IN_TEXT_SECTION to 1. >> >> As described in the bugzilla entry, this hook assumed it will get >> c

Re: [Patch, avr] Fix PR 71151

2016-06-04 Thread Georg-Johann Lay
Senthil Kumar Selvaraj schrieb: Hi, This patch fixes PR 71151 by eliminating the TARGET_ASM_FUNCTION_RODATA_SECTION hook and setting JUMP_TABLES_IN_TEXT_SECTION to 1. As described in the bugzilla entry, this hook assumed it will get called only for jumptable rodata for functions. This

Re: [Patch, avr] Fix PR 71151

2016-06-03 Thread Georg-Johann Lay
Senthil Kumar Selvaraj schrieb: Hi, This patch fixes PR 71151 by eliminating the TARGET_ASM_FUNCTION_RODATA_SECTION hook and setting JUMP_TABLES_IN_TEXT_SECTION to 1. As described in the bugzilla entry, this hook assumed it will get called only for jumptable rodata for functions. This

[Patch, avr] Fix PR 71151

2016-06-03 Thread Senthil Kumar Selvaraj
Hi, This patch fixes PR 71151 by eliminating the TARGET_ASM_FUNCTION_RODATA_SECTION hook and setting JUMP_TABLES_IN_TEXT_SECTION to 1. As described in the bugzilla entry, this hook assumed it will get called only for jumptable rodata for functions. This was true until 6.1, when a comm