Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2019-03-21 Thread Thomas Schwinge
Hi! On Thu, 28 Feb 2019 18:02:32 +0100, Thomas Schwinge wrote: > On Fri, 02 Jan 2015 12:28:10 +0100, Tobias Burnus wrote: > > [...] > > > > I additionally propagated the dg-compile-aux-modules support to caf.dg > > That got committed in r219143: > > > --- a/gcc/testsuite/gfortran.dg/coarray

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2019-02-28 Thread Thomas Schwinge
Hi! On Fri, 02 Jan 2015 12:28:10 +0100, Tobias Burnus wrote: > [...] > > I additionally propagated the dg-compile-aux-modules support to caf.dg That got committed in r219143: > --- a/gcc/testsuite/gfortran.dg/coarray/caf.exp > +++ b/gcc/testsuite/gfortran.dg/coarray/caf.exp > @@ -43,6 +43,21

Re: [Patch, Fortran] Fix previous patch (was: Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules)

2015-01-04 Thread Dominique d'Humières
Dear Tobias, I have done a clean bootstrap with your patch and run make -k check-gfortran RUNTESTFLAGS="caf.exp --target_board=unix'{-m32,-m64}’" without regression. Thanks, Dominique > Le 4 janv. 2015 à 19:57, Tobias Burnus a écrit : > > Attached is a regtested patch, which fixes the issu

[Patch, Fortran] Fix previous patch (was: Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules)

2015-01-04 Thread Tobias Burnus
Attached is a regtested patch, which fixes the issue. Additionally, the variable visibility (TREE_PUBLIC) is now depending on the private attribute (copied from the module var generation) and I mark the tree as DECL_NONALIASED. The former I also did for proc-pointers, which is an unrelated patc

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-03 Thread Dominique d'Humières
Compilation with the new patch fails with ../../work/gcc/fortran/trans-decl.c: In function 'void gfc_build_qualified_array(tree, gfc_symbol*)': ../../work/gcc/fortran/trans-decl.c:855:25: error: 'cur_module' was not declared in this scope gfc_module_add_decl (cur_module, token); Dominique

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-03 Thread Tobias Burnus
Dominique d'Humières wrote: From a quick test, with the patch I still see the error with -m32 It helps if one actually adds the decl. The following (still untested) should help. I also marked the token as nonaliasing (it really should!) and added for proc pointers the tree-public optimizatio

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-03 Thread Dominique d'Humières
From a quick test, with the patch I still see the error with -m32 /var/folders/8q/sh_swgz96r7f5vnn08f7fxr0gn/T//cc8Yz3Jr.s:18:non-relocatable subtraction expression, "__F.caf_token__global_coarrays_MOD_b" minus "L1$pb" /var/folders/8q/sh_swgz96r7f5vnn08f7fxr0gn/T//cc8Yz3Jr.s:18:symbol: "

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-03 Thread Tobias Burnus
Dominique Dhumieres wrote: The test gfortran.dg/coarray/codimension_2.f90 fails on x86_64-apple-darwin14 with -m32 (see https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg00185.html). The error is [...] Yes, there seems to be something wrong. The module has: U _F.caf_token__gl

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-03 Thread Dominique Dhumieres
Happy New Year to all. The test gfortran.dg/coarray/codimension_2.f90 fails on x86_64-apple-darwin14 with -m32 (see https://gcc.gnu.org/ml/gcc-testresults/2015-01/msg00185.html). The error is gfc /opt/gcc/work/gcc/testsuite/gfortran.dg/coarray/codimension_2.f90 /opt/gcc/work/gcc/testsuite/gfort

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-02 Thread Mike Stump
On Jan 2, 2015, at 3:28 AM, Tobias Burnus wrote: > As found by Alessandro: Statically allocated coarrays in declared in the > specification part of a module didn't work (link-time failure). The reason > was that the associated coarray token was wrongly mangled and not a public > tree. > > I ad

Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-02 Thread FX
> As found by Alessandro: Statically allocated coarrays in declared in the > specification part of a module didn't work (link-time failure). The reason > was that the associated coarray token was wrongly mangled and not a public > tree. > > I additionally propagated the dg-compile-aux-modules s

[Patch, Fortran + Testsuite] Fix coarray handling in modules

2015-01-02 Thread Tobias Burnus
As found by Alessandro: Statically allocated coarrays in declared in the specification part of a module didn't work (link-time failure). The reason was that the associated coarray token was wrongly mangled and not a public tree. I additionally propagated the dg-compile-aux-modules support to c