Re: [Patch, Fortran] PR 85088: improve diagnostic for bad INTENT declaration

2018-06-10 Thread Janus Weil
2018-06-10 9:02 GMT+02:00 Janus Weil : > Hi Thomas, > >> I like what the patch does. However, I have one concern. >> >>> * decl.c (match_attr_spec): Synchronize the DECL_* enum values with >>> the >>> INTENT_* values from the enum 'sym_intent'. >> >> >> This part >> >> + { GFC_DECL_BEGIN

Re: [Patch, Fortran] PR 85088: improve diagnostic for bad INTENT declaration

2018-06-10 Thread Janus Weil
Hi Thomas, > I like what the patch does. However, I have one concern. > >> * decl.c (match_attr_spec): Synchronize the DECL_* enum values with >> the >> INTENT_* values from the enum 'sym_intent'. > > > This part > > + { GFC_DECL_BEGIN = 0, DECL_ALLOCATABLE = GFC_DECL_BEGIN, > +DECL

Re: [Patch, Fortran] PR 85088: improve diagnostic for bad INTENT declaration

2018-06-09 Thread Thomas Koenig
Hi Janus, I like what the patch does. However, I have one concern. * decl.c (match_attr_spec): Synchronize the DECL_* enum values with the INTENT_* values from the enum 'sym_intent'. This part + { GFC_DECL_BEGIN = 0, DECL_ALLOCATABLE = GFC_DECL_BEGIN, +DECL_IN = INTENT_IN, DEC

[Patch, Fortran] PR 85088: improve diagnostic for bad INTENT declaration

2018-06-09 Thread Janus Weil
Hi all, attached is a small patch that approves some diagnostics for INTENT declarations. It also takes care of a TODO note in decl.c. I had regtested a previous version of the patch without problems and will do another run with this one before checking in. Ok for trunk? Cheers, Janus 2018-06-