Re: [Patch, Fortran] No-op Patch - a.k.a. FINAL wrapper update

2012-12-02 Thread Janus Weil
Hi Tobias, >> In my version of the patch I introduced a routine 'gfc_is_finalizable' to >> perform this decision. > > > Okay. How about the following patch? It's the same without the renaming. > > Build an regtested on x86-64-linux.* > OK for the trunk? Yes, looks ok to me. Thanks for the patch!

Re: [Patch, Fortran] No-op Patch - a.k.a. FINAL wrapper update

2012-11-30 Thread Tobias Burnus
Am 30.11.2012 11:22, schrieb Janus Weil: In my version of the patch I introduced a routine 'gfc_is_finalizable' to perform this decision. Okay. How about the following patch? It's the same without the renaming. Build an regtested on x86-64-linux.* OK for the trunk? * * * I will submit your g

Re: [Patch, Fortran] No-op Patch - a.k.a. FINAL wrapper update

2012-11-30 Thread Janus Weil
2012/11/30 Janus Weil : > Hi, > >>> one thing that I do not like about your patch is the modification of >>> "gfc_find_derived_vtab": You create two versions of it, one of which creates >>> the vtab if it does not exist, while the other version does not do this. >>> [...] can you explain to me why

Re: [Patch, Fortran] No-op Patch - a.k.a. FINAL wrapper update

2012-11-30 Thread Janus Weil
Hi, >> one thing that I do not like about your patch is the modification of >> "gfc_find_derived_vtab": You create two versions of it, one of which creates >> the vtab if it does not exist, while the other version does not do this. >> [...] can you explain to me why this would be necessary? > > >

Re: [Patch, Fortran] No-op Patch - a.k.a. FINAL wrapper update

2012-11-29 Thread Tobias Burnus
Am 29.11.2012 23:51, schrieb Janus Weil: one thing that I do not like about your patch is the modification of "gfc_find_derived_vtab": You create two versions of it, one of which creates the vtab if it does not exist, while the other version does not do this. [...] can you explain to me why thi

Re: [Patch, Fortran] No-op Patch - a.k.a. FINAL wrapper update

2012-11-29 Thread Janus Weil
Hi Tobias, > effectively, this patch doesn't do anything. Except, it updates the – > deactivated – finalization wrapper. > > > Note: This patch does not include any code to actually call the finalization > wrapper. Nor is the modified code ever called in gfortran. However, that > patch paves the r

[Patch, Fortran] No-op Patch - a.k.a. FINAL wrapper update

2012-11-27 Thread Tobias Burnus
Dear all, effectively, this patch doesn't do anything. Except, it updates the – deactivated – finalization wrapper. Note: This patch does not include any code to actually call the finalization wrapper. Nor is the modified code ever called in gfortran. However, that patch paves the road to a