Re: [Patch, Fortran] Fix some issues found by Coverity's static-code analysis scan

2012-09-16 Thread Tobias Burnus
Mikael Morin wrote: On 15/09/2012 19:36, Tobias Burnus wrote: As a pre-script: Will you look at Paul's revised assignment patch - or should I do it? I looked at it twice or so, and couldn't get the double temporary thing. I'll get back to it. Thanks! Thanks for the analysis. Will you create

Re: [Patch, Fortran] Fix some issues found by Coverity's static-code analysis scan

2012-09-16 Thread Mikael Morin
On 15/09/2012 19:36, Tobias Burnus wrote: > Hi Mikael, > > thanks for your comments. > > As a pre-script: Will you look at Paul's revised assignment patch - or > should I do it? I looked at it twice or so, and couldn't get the double temporary thing. I'll get back to it. > If you want to know th

Re: [Patch, Fortran] Fix some issues found by Coverity's static-code analysis scan

2012-09-15 Thread Tobias Burnus
Hi Mikael, thanks for your comments. As a pre-script: Will you look at Paul's revised assignment patch - or should I do it? Mikael Morin wrote: [Out of bounds] diff --git a/gcc/fortran/array.c b/gcc/fortran/array.c index 44ec72e..1611c3b 100644 --- a/gcc/fortran/array.c +++ b/gcc/fortran/ar

Re: [Patch, Fortran] Fix some issues found by Coverity's static-code analysis scan

2012-09-15 Thread Mikael Morin
Argh! Paul OKed the patch already. Here are my comments anyway. On 15/09/2012 11:46, Tobias Burnus wrote: > Dear all, > > this patch fixes some of the warning showing up for gcc/fortran at > http://scan.coverity.com/. Coverity sells static C/C++/C#/Java code > analyzers and offer scanning to open

Re: [Patch, Fortran] Fix some issues found by Coverity's static-code analysis scan

2012-09-15 Thread Paul Richard Thomas
Dear Tobias, > Build and regtested on x86-64-linux. > OK for the trunk? OK for trunk - thanks for the patch. Cheers Paul

[Patch, Fortran] Fix some issues found by Coverity's static-code analysis scan

2012-09-15 Thread Tobias Burnus
Dear all, this patch fixes some of the warning showing up for gcc/fortran at http://scan.coverity.com/. Coverity sells static C/C++/C#/Java code analyzers and offer scanning to open-source projects. The result looks like http://www.coverity.com/images/products/static-analysis/screenshot-1-lar