Re: [Patch, Fortran] Convert gfc_fatal_error to common diagnostics

2014-11-18 Thread Manuel López-Ibáñez
On 15 November 2014 10:23, Tobias Burnus wrote: > Especially since color diagnostic is now the default [1], it makes sense to > convert more gfortran diagnostics to use the common diagnostics. > > For an example, see [1]. That also brings all the nice features like placing > the warning option in

Re: [Patch, Fortran] Convert gfc_fatal_error to common diagnostics

2014-11-15 Thread FX
> Thus, I don't think it should be put into the wiki. (Admittedly, I also do > not know which page you are referring to.) In any case, there are several PRs > about issues fixed by the on-going change to the common diagnostics. OK. (The page I was referring to is here: https://gcc.gnu.org/wiki/

Re: [Patch, Fortran] Convert gfc_fatal_error to common diagnostics

2014-11-15 Thread Tobias Burnus
FX wrote: Please document, in the source, the difference between gfc_fatal_error and gfc_fatal_error_1. They currently have the same generic description, which wouldn’t help people writing new front-end code to know which one to use. Moreover, if the transition will not be complete soon (or in

Re: [Patch, Fortran] Convert gfc_fatal_error to common diagnostics

2014-11-15 Thread FX
> Build and regtested on x86-64-gnu-linux. > OK for the trunk? Please document, in the source, the difference between gfc_fatal_error and gfc_fatal_error_1. They currently have the same generic description, which wouldn’t help people writing new front-end code to know which one to use. Moreover

[Patch, Fortran] Convert gfc_fatal_error to common diagnostics

2014-11-15 Thread Tobias Burnus
Especially since color diagnostic is now the default [1], it makes sense to convert more gfortran diagnostics to use the common diagnostics. For an example, see [1]. That also brings all the nice features like placing the warning option in brackets: Warning: USE statement at (1) has no ONLY