Hello world,
I just committed the attached patch as obvious, simple and having
no user impact), as r15-7575.
Previously, a dump looked like
attributes: (VARIABLE IMPLICIT-SAVE BIND(C) SAVE-IMPLICIT)
and now it is
attributes: (VARIABLE IMPLICIT-SAVE BIND(C))
Best regards
Thom
Hello world,
I just committed the fix for PR 11845 as obvious and simple, as
r15-7552-gfd00010ba21c04bddb20aef52f62de5636075067 .
Fix PR 118884, Lapack build failure.
The fix for PR 118845 introduced new checks, which in turn exposed
a case where the typespec information on a symbol generated s
Hello world,
I have committed the attached patch as obvious and simple after
regression-testing. I could not construct a test case that
actually failed, though, but the logic was wrong (pointer aliasing
and the field that was accessed had the wrong offset).
Commit is r15-6831-g40754a3b9bef83bf4
On Sat, Nov 16, 2024 at 02:55:11PM +0100, Thomas Koenig wrote:
>
> Steve found a test case where unsigned constants were not handled
> in a module. Single-line patch committed as obvious and simple,
> r15-5341-g66096151afc6631f8f2a3458b154c5daa822b963 .
>
> Best regards
>
> Thomas
>
Than
Hello world,
Steve found a test case where unsigned constants were not handled
in a module. Single-line patch committed as obvious and simple,
r15-5341-g66096151afc6631f8f2a3458b154c5daa822b963 .
Best regards
Thomas
Handle unsigned constants for module I/O.
gcc/fortran/ChangeLog:
Hello world,
I just pushed Steve's patch for module support to trunk as obvious, as
https://gcc.gnu.org/g:2847a541c1f19b67ae84be8d0f6dc8e1f9371d16 .
Best regards
Thomas
gcc/fortran/ChangeLog:
* module.cc (bt_types): Add BT_UNSIGNED.
gcc/testsuite/ChangeLog:
* gfortra
The following has been committed per discussion in the subject PR.
commit 95b70545331764c85079a1d0e1e19b605bda1456 (HEAD -> master,
origin/master, origin/HEAD)
Author: Jerry DeLisle
Date: Wed Dec 13 19:04:50 2023 -0800
fortran: Add degree based trig functions for F2023
PR f
Hi all, hi Harald,
thanks for the review. I choose to use gfc_replace_expr() and retested.
Everything went fine now.
Also thank you clarifying the pdt as a component in a derived type and that
that is still a bug and I didn't do it wrong.
I have pushed the attached patch seconds ago.
Thanks for
Hello world,
committed to trunk as obvious and simple.
Best regards
Thomas
Set DECL_ARTIFICIAL on gfortran internal variables.
It seems we sometimes use DECL_ARTIFICIAL as choosing between
different code paths. In order not to make -fdebug-aux-vars
do different things, set DECL_ARTIF
Hello world,
I have just committed as obvious and simple (and as no-user-impact)
an improvement to the tree dump, plus the ability to call
debug(array_reference) in the debugger. The revision is
r11-5967.
The dump for a coarray assignment now looks like
ASSIGN main:a(FULL)[THIS_IMAGE] 4.200
Committed to master as obvious.
Thanks,
Harald
Fortran texi: Fix description of GFC_RTCHECK_* macros.
gcc/fortran/ChangeLog:
* gfortran.texi: Fix description of GFC_RTCHECK_* to match actual
code.
diff --git a/gcc/fortran/gfortran.texi b/gcc/fortran/gfortran.texi
index 453b30
Hi,
in the code about DO loop warning I recently introduced, there was
a hidden NULL pointer dereference found by Jürgen Reuter and fixed
as obvious and simple in r11-2636.
Fix NULL pointer dereference in doloop_contained_function_call.
Thanks to Jürgen for the bug report and to Dominique for s
Hello world,
I have just committed the attached patch as simple and obvoius.
The problem was that, for a test case like
module f_global_vars_m
use, intrinsic :: iso_c_binding, sp => c_float, dp => c_double
implicit none
real(dp), bind(c) :: one= 1.0_dp, four= 4.0_dp
end module f_global_vars_m
t
Hello world,
I have just committed the attached patch to master as obvious and
simple. Explanation is in the ChangeLog below.
Best regards
Thomas
Fix ICE on warning with new interface check (the patch for PR 27318).
In the test case, there was a warning about INTENT where an EXTERNAL
Am 30.06.20 um 13:11 schrieb Thomas Koenig:
PR fortran/95355
That should have been PR 955366.
Regards
Thomas
Hello world,
fortunately, upon inspection the fix for this PR turned out to be
obvious (and simple). I have committed it as such. Unless there
is unexpected fallout, I intend to backport it to gcc-10 over
the weekend so it can still be included into 10.2.
Regression-tested on x86_64 and on a b
Hello world,
I just committed the attached patch as obvious and simple. It's
one line, or alternatively, 24 characters long :-)
Best regards
Thomas
Do not generate recursion check for compiler-generated procedures.
This one-line fix removes a check for recursion for procedures
which a
Hello world,
I just committed the attached patch to master as obvious and simple
after regression-testing. Will also backport to gcc-10, where
the original regression occurred.
Regards
Thomas
Handle AR_FULL vs. AR_FULL in dependency checking.
Previously, handling of full vs. full ref
Committed as obvious, simple and risk-free after checking
that it still compiles.
It does not fix the PR in question, it it just something that
was noted in one of the comments.
Regards
Thomas
Avoid crash when global symbol table is empty with -fdump-fortran-global.
This just avoids a
Hi,
I just committed as obvious and simple the attached patch,
as r11-1297-g4644e8f15f835a9934a8d289ee08ba4cb46cbfac .
Regards
Thomas
Always use locations from get and put arguments for error messages.
A simple and obvios patch - the error location was taken
from a variable that was n
Hello world,
I have just committed as obvious and simple the attached patch -
adding an early error return.
This is a 9/10/11 Regression, so I will commit to the other
branches in a few days.
Regards
Thhomas
Fixes a hang on an invalid ID in a WAIT statement.
gcc/fortran/ChangeLog:
2
Hello world,
rather than touch 50% of the files in our libfortran
subdirectory, I opted for the simple and obvious
way - if the RHS is a pointer which may have a span,
just create a temporary. (We're also qutie close to
a release candidate if I count the P1 regressions
correctly, so this is not
Hi,
I just committed the attached patch as obvious and simple.
Since this is a regression, I will backport to gcc 9 and
gcc 8 shortly.
(I'm attaching the patch as txt file in the hope it will not
be munged in the web archive).
Regards
Thomas
Fix PR 94270 by not warning about artifical
All is about OpenACC. First, when testing, I found out that "kernels
loop" wasn't checked for – only serial/parallel loop and an "acc loop".
For nested loops, besides using the "collapse" clause also the "tile"
clause can be used. Internally, those are processed identically (on the
FE side) bu
Another trival patch.
Regards
Thomas
Add missing closing parenthises in error message.
2020-02-23 Thomas Koenig
PR fortran/93889
* interface.c (compare_parameter): Fix error message.
diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
index 5f889fb31
Hello world,
New year, new bug, new patch :-)
I have just committed as obvious and simple the attached patch
as r279821, where we failed to account for %re and %im in dependency
checking. This is a 10 regression, gcc 9 works.
Regards
Thomas
Handle REF_INQUIRY for dependency checking.
Hello world,
this fixes a regression introduced by my inline repacking patch.
With the test case, it is simple and obvious enough - do not repack
an assumed rank argument (which makes no sense).
Committed as obvious and simple as r279203 after regression-testing.
2019-12-10 Thomas Koenig
Hello world,
I have just committed the attached patch as obvious and simple
as r279180.
The ICE for the test case occurred because a previous error
had left the derived field of the typespec NULL. Just returning
"invalid type" or "invalid class" in such a case is enough
to cure the ICE.
Regards
Hello world,
yet another obvious and simple fix: You cannot really associate
the main program with a variable. Committed as r279088 after
regression-testing.
Regards
Thomas
2018-12-08 Thomas Koenig
PR fortran/92780
* resolve.c (resolve_assoc_var): Issue error if
Hi,
I just committed the patch below as obvious to fix a 9/10 regression
when directly calling BLAS routines for matmul. Will backport
to gcc-9 soon.
Regards
Thomas
Commit symbol for external BLAS routine when translating MATMUL to *GEMM.
2019-11-09 Thomas Koenig
PR fortr
Hello world,
I have committed the attached patch as obvious and simple after
regression-testing.
It fixes an ICE on valid for a corner case, so I don't really
feel that it needs to be backported. If anybody disagrees,
please speak up (or do it yourself :-)
Regards
Thomas
2019-10-13
Hi,
I just committed as simple and obvious the patch below. This
fixes a 8/9/10 regression where a false positive with -Wdo-subscript
(which we know about) was compounded by an also invalid error.
Fixed by suppressing errors at the right time.
I will also commit the patch to the other affected
Hi,
I just committed the attached patch as obvious ans simple. No impact
on user code, just to make internal debugging easier.
Regards
Thomas
2019-06-16 Thomas Koenig
* dump_parse_tree (debug): Add verison for formal arglist.
Do not crash when a gfc_expr is NULL.
In
Hello world,
in the absence of a test case for PR 90539, I'm taking a shotgun
approach: Fix something that appears strange in the debug logs
and see if this more or less accidentally fixes the problem.
If not, at least there is one fewer point to look at.
I have committed the attached patch as o
Hello world,
I have just committed the attached patch as obvious and simple. It
fixes an error message so that it can be extracted for translation.
No test case because it does not change anything (which was verified
by regression-testing).
Regards
Thomas
2019-04-11 Thomas Koenig
Hello world,
I have attached the patch below as obvious and simple (it is a
one-liner). The problem was a latent bug exposed by my recent
commit for PR 78865, where the check for subroutine entries
was done on the main symbol instead of the entry. Provision
for doing this for the entry master we
Hello world,
I have just committed this patch as obvious to make debugging
a bit easier. No user impact, the code compiles :-)
Regards
Thomas
2019-03-31 Thomas Koenig
* dump-parse-tree.c (debug): Add for symbol_attribute *,
symbol_attribute and gfc_ref * arguments.
Hi,
I have committed the following patch preapproved by Thomas on BZ as revision
r267906.
2019-01-13 Dominique d'Humieres
PR fortran/88803
* gfortran.texi: Replace @xref with @ref and adjust the sentence.
--- ../_clean/gcc/fortran/gfortran.texi 2019-01-12 16:27:23.0
Hell world,
as part of the contiguous improvement process in gfortran, I have
committed the patch below as obvious. gfortran now does not pack/unpack
if a function result is contiguous.
Regards
Thomas
2019-01-13 Thomas Koenig
PR fortran/57992
* trans-array.c (gfc_
Hi,
I just committed the attached patch as obvious and simple. The problem
was that clobbering of intent(out) clobbered the whole variable, instead
of only the element that was actually clobbered.
There is still some optimization work that can be done here, but I will
defer that to a later date
Originally, the idea about checking for missing location information
when not configured for release is to catch errors when adding new
code, so forgetting to add the info will show up right away on
regression testing.
From time to time, a user can stumble across something like that
and get a con
Am Mo., 24. Sep. 2018 um 19:16 Uhr schrieb Thomas Koenig
:
>
> Hello world,
>
> another obvious and simple one-line fix for fallout from the INTENT(OUT)
> clobber patch. Committed as r264539, after regression-testing.
>
> It seems our testsuite is not testing as many combinations in the
> language
Hello world,
another obvious and simple one-line fix for fallout from the INTENT(OUT)
clobber patch. Committed as r264539, after regression-testing.
It seems our testsuite is not testing as many combinations in the
language as I thought :-)
Regards
Thomas
2018-09-24 Thomas Koenig
Hi Thomas,
I'm seeing some more fallout from your intent(out) patch:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87401
Cheers,
Janus
Am So., 23. Sep. 2018 um 22:23 Uhr schrieb Thomas König :
>
> Hello world,
>
> committed as obvious after regression-testing. Instead of spending
> a lot of wor
Hello world,
committed as obvious after regression-testing. Instead of spending
a lot of work trying to reducing the test case, I used all of it
(retainging the copyright notice).
Regards
Thomas
2018-09-23 Thomas Koenig
PR fortran/87397
* gfc_conv_procedure_call: D
Hello world,
the attached patch, committed as obvious, fixes a regression
introduced by yesterday's patch. Apparently, clobber statements
are even more finicky that I thought and do not work for saved
variables either.
Regards
Thomas
2018-09-23 Thomas Koenig
PR fortran/873
Hi all,
I have just committed as obvious a small patch that fixes two very
related PRs concerning polymorphic assignments, by making sure that
the relevant vtabs (including copy procedures) are generated:
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=264350
Cheers,
Janus
Hi all,
I have just committed a small patch for an ICE-on-invalid problem:
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=263854
The patch was approved by Jerry on bugzilla and I checked that it
shows no failures in the testsuite.
Cheers,
Janus
Hello world,
I have just committed the attached patch as obvious after
regression-testing.
Since this fixes a regression, I will backport to gcc8 and gcc7 in
the next days.
Regards
Thomas
2018-06-06 Thomas Koenig
PR fortran/85641
* frontend-passes.c (is_fe_temp): A
Hello world,
I have just committed r258900 as obvious on trunk to fix an
out-of-memory error in front-end optimization, which was
caused by gfortran's AST being in an inconsistent state.
I suspect that this will also fix other, as yet unknown
errors.
I will backport to the other affected branch
Patch committed as obvious at revision r257750.
Dominique
--- trunk/gcc/fortran/decl.c2018/02/16 17:42:08 257749
+++ trunk/gcc/fortran/decl.c2018/02/16 18:01:02 257750
@@ -3302,7 +3302,7 @@
kind_expr = gfc_copy_expr (c1->initializer);
else if (!(actua
Hello world,
I have just committed the attached patch as obvious and simple.
Before, the C binding label was ignored for generating
function prototypes with the -fc-prototypes option.
2018-01-31 Thomas Koenig
* dump-parse-tree.c (write_proc): Use sym_name (which may
be sym->b
Hi,
I just committed the patch below as obvious.
Index: ChangeLog
===
--- ChangeLog (revision 257256)
+++ ChangeLog (working copy)
@@ -1,5 +1,10 @@
2018-01-31 Janne Blomqvist
+ * trans-const.c (gfc_conv_string_init): U
Hello world,
another obvious fix, this time for an ice-on-invalid regression,
committed after regression-testing.
Regards
Thomas
2017-01-30 Thomas Koenig
PR fortran/84134
* array.c (gfc_ref_dimen_size): Whitespace fixes. If stride is
zero, return false.
20
Hi all,
I have just committed an obvious patch that adds a closing bracket in
a dg-options directive in the testsuite as r257208:
Index: gcc/testsuite/gfortran.dg/pr68318_1.f90
===
--- gcc/testsuite/gfortran.dg/pr68318_1.f90(revi
Hello world,
I have just committed the attached patch as obvious, after regtesting.
Regards
Thomas
2018-01-30 Thomas Koenig
PR fortran/84133
* frontend-passes (matmul_to_var_expr): Return early if
in association list.
(inline_matmul_assign): Likewise
Hello world,
I have committed the patch below as obvious. This one had
the distinction that two people came up with exactly the
same pach independently :-)
Regards
Thomas
2018-01-13 Thomas Koenig
PR fortran/83803
* dump-parse-tree.c (write_
Index: dump-parse
Am 02.01.2018 um 19:00 schrieb Thomas Koenig:
Hello world,
I have committed the patch below as obvious to fix the
same bug on gcc-7 that my recent patch fixed on trunk.
... of course, better with a patch which includes
the changes instead of the ChangeLog entries:
Index: fortran/simplify.c
==
Hello world,
I have committed the patch below as obvious to fix the
same bug on gcc-7 that my recent patch fixed on trunk.
2018-01-02 Thomas Koenig
PR fortran/83650
* simplify.c (gfc_simplify_cshift): Correct contition for
negative shifts.
2018-01-02 Thomas Koenig
Hello world,
I have committed the fix for the second part (and original
test case) of PR 83224 as obvious after regression-testing
as r255331.
Regards
Thomas
2017-12-01 Thomas Koenig
PR fortran/83224
* frontend-passes.c (create_var): Also handle
character ar
Hello world,
I just committed the attached patch as obvious and simple to trunk,
r255294.
Regards
Thomas
2017-12-01 Thomas Koenig
PR fortran/83224
* frontend-passes.c (realloc_string_callback): Handle
case for which the RHS is an array expression.
2017-12-0
Hi!
Committed as obvious as r254082.
thanks,
Index: gcc/fortran/match.c
===
--- gcc/fortran/match.c (revision 254081)
+++ gcc/fortran/match.c (working copy)
@@ -6204,7 +6204,7 @@
return MATCH_YES;
syntax:
- gfc_error ("Ssyntax
All,
The simple attached patch which fixes PR 82511 has been committed to
trunk as r253791. It regtests on x86_64-redhat-linux-gnu.
The issue was an ICE when a variable containing a BT_UNION (basetype
12) component was given in a I/O list. The patch treats the BT_UNION
component as a derived type
Hello,
Le 08/10/2017 à 15:15, Paul Richard Thomas a écrit :
I thought that the suggestion to add the original input lines was not
bad. It would be even better if -fdump-tree-original could do that.
There is -fdump-tree-original-lineno. I think it does that.
Cheers
Mikael
Hi Paul,
I thought that the suggestion to add the original input lines was not
bad. It would be even better if -fdump-tree-original could do that. I
often time find myself putting a line under the spotlight in a
contained subroutine.
This should be doable.
What should be the perferred format
Hi Thomas,
I thought that the suggestion to add the original input lines was not
bad. It would be even better if -fdump-tree-original could do that. I
often time find myself putting a line under the spotlight in a
contained subroutine.
Thanks for working on -fdump-parse-tree.
Cheers
Paul
On 8
Hello world,
I have committed a few small fixes for -fdump-fortran-original and
friends.
Since there was interest on c.l.f from somebdoy who actually wanted to
use the dump for something useful, I have also clarified in the docs
that this is something that is not guaranteed to work between relea
Hello world,
I noticed that EXEC_WAIT wasn't handled in the Fortran tree dump.
This patch does that. While preparing this, I also noticed that
the values for the END and EOR tags were interchanged and fixed
this as well.
Committed as obvious and simple.
Just a cleanup for the time when WAIT ac
Hello world,
I have committed the attached patch as obvious after regression-testing.
It removes the wrong warning from my recend DO warning patch that Jakub
pointed out. The test case that is restored with this patch is enough
to catch any regression.
Regards
Thomas
2017-09-26 Thom
This patch removes an unnecessary fold_convert to boolean_type_node at
the end of gfc_likely and gfc_unlikely. It makes no difference to the
generated code, but makes tree dumps a little bit cleaner.
2017-09-25 Janne Blomqvist
* trans.c (gfc_unlikely): Remove unnecessary fold_convert.
Patch committed after approval by Thomas Koenig on IRC
Dominique
Hello world,
Steve had analyzed the bug and provided a patch in the PR;
I modified the patch stylistically and committed it as
obvious after regression-testing (r253123).
Thanks Steve!
Since this is a regression, I will backport soon.
Regards
Thomas
2017-09-24 Thomas Koenig
Hello world,
I have just committed the attached patch as obvious and simple
after testing.
Regards
Thomas
2017-07-24 Thomas Koenig
* dump-parse-tree.c (show_symbol): Show binding label if present.
Index: dump-parse-tree.c
===
I have committed as obvious the following patch at revision r250083
--- ../_clean/gcc/fortran/class.c 2017-04-14 23:53:52.0 +0200
+++ gcc/fortran/class.c 2017-07-08 12:25:51.0 +0200
@@ -310,7 +310,6 @@ class_array_ref_detected (gfc_ref *ref,
else if (ref->next && ref-
Hello world,
I have just committed as obvious a patch fixing a wrong
calculation for allocating the size of a return variable
in inline matmul (PR 80904). I will backport to the
other affected branches in the near future.
Regards
Thomas
2017-05-28 Thomas Koenig
* frontend-
Hello world,
I just committed the attached patch as obvious.
Regards
Thomas
2017-05-24 Thomas Koenig
* dump-parse-tree.c (show_expr): Replace stdout
with dumpfile for showing values.
Index: dump-parse-tree.c
Hi all,
I have just committed a close-to-obvious patch for PR 80361, as
approved by Thomas on bugzilla:
https://gcc.gnu.org/viewcvs?rev=246934&root=gcc&view=rev
I will backport it to the 5 and 6 branches after a week or so ...
Cheers,
Janus
Hello world,
I have committed the attached patch as obvious and simple
after regression-testing, as rev. 246388.
This is a case where the location checking pass did its job
and found a place where the location information was indeed
missing.
Regards
Thomas
2017-03-22 Thomas Koenig
2016-12-18 11:25 GMT+01:00 Janus Weil :
> 2016-12-18 11:18 GMT+01:00 Mikael Morin :
>> Le 17/12/2016 à 22:49, Janus Weil a écrit :
>>>
>>> Hi Mikael,
>>>
> I have just committed a completely obvious patch for this PR. All it
> does is rearrange some expressions to avoid an ICE (see attachme
2016-12-18 11:18 GMT+01:00 Mikael Morin :
> Le 17/12/2016 à 22:49, Janus Weil a écrit :
>>
>> Hi Mikael,
>>
I have just committed a completely obvious patch for this PR. All it
does is rearrange some expressions to avoid an ICE (see attachment):
>>> I have made a late review of it, a
Le 17/12/2016 à 22:49, Janus Weil a écrit :
Hi Mikael,
I have just committed a completely obvious patch for this PR. All it
does is rearrange some expressions to avoid an ICE (see attachment):
I have made a late review of it, and I think it’s not as innocent as it
seems.
With it, if the first
2016-12-17 22:49 GMT+01:00 Janus Weil :
> Hi Mikael,
>
>>> I have just committed a completely obvious patch for this PR. All it
>>> does is rearrange some expressions to avoid an ICE (see attachment):
>>>
>> I have made a late review of it, and I think it’s not as innocent as it
>> seems.
>> With i
Hi Mikael,
>> I have just committed a completely obvious patch for this PR. All it
>> does is rearrange some expressions to avoid an ICE (see attachment):
>>
> I have made a late review of it, and I think it’s not as innocent as it
> seems.
> With it, if the first element’s formal is not properly
Hello,
Le 30/11/2016 à 10:52, Janus Weil a écrit :
Hi all,
I have just committed a completely obvious patch for this PR. All it
does is rearrange some expressions to avoid an ICE (see attachment):
I have made a late review of it, and I think it’s not as innocent as it
seems.
With it, if the f
Hi all,
I have just committed to trunk another obvious one-line fix for an
ICE-on-invalid regression:
https://gcc.gnu.org/viewcvs?rev=243020&root=gcc&view=rev
I plan to backport this to the gcc-6 branch within a week or so.
Cheers,
Janus
Index: gcc/fortran/primary.c
Hi all,
I have just committed a completely obvious patch for this PR. All it
does is rearrange some expressions to avoid an ICE (see attachment):
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=243005
Cheers,
Janus
Index: gcc/fortran/interface.c
===
Hi,
committed the following as obvious:
Index: ChangeLog
===
--- ChangeLog (revision 242883)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2016-11-25 Janne Blomqvist
+
+ * intrinsic.texi: Fix ptrdiff_t typo in ISO_C_BIND
Hello world,
I have just committed the attached patch as obvious. No test case,
the function is only supposed to be called when debugging the
compiler itself.
Regards
Thomas
2016-11-14 Thomas Koenig
* dump-parse-tree.c (show_code): Add prototype.
(gfc_debug_code):
Hi all,
I have just committed an obvious fix for a rejects-valid problem,
where a procedure named 'end' was not properly flagged as a procedure:
https://gcc.gnu.org/viewcvs?rev=242352&root=gcc&view=rev
Cheers,
Janus
Index: gcc/fortran/decl.c
==
Hi Andre,
> sorry, when I stepped on your toes. That was not my intention.
well, I kind of got the impression that me committing 'obvious'
patches was somehow getting in conflict with _your_ toes (though I
don't quite understand why). I care as much about the quality of
gfortran as you do, trust
Hi Janus,
sorry, when I stepped on your toes. That was not my intention. While looking at
your patch and its environment those thoughts came to me. Good that you could
destroy my doubts. Thank you very much.
> In fact I have not thought about any further cases. Since you're not
> giving full exam
Hi Andre,
> well, is it really that obvious?
well ... what can I say. If you wanna be strict about it, I guess
there is no such thing as an "obvious patch". There is basically
always something that you can miss, or that can be improved. Mikael's
patch was obvious to me in the sense that it is cle
Hi Janus,
well, is it really that obvious? It fixes the ICE, correct. But what about
cases where the actual has an explicit interface, but is not a variable? Like
in:
function f()
integer :: f
end function
call sub(f())
! sub() defined as in the pr.
I haven't checked whether that is valid Fo
Hi all,
I have committed yet another obvious ice-on-invalid fix:
https://gcc.gnu.org/viewcvs?rev=242020&root=gcc&view=rev
Cheers,
Janus
Index: gcc/fortran/interface.c
===
--- gcc/fortran/interface.c (Revision 241993)
+++ gcc/for
Hi all,
I just committed a close-to-obvious fix for PR60777 (ok'd by Steve in
the PR), see attachment:
https://gcc.gnu.org/viewcvs?rev=242009&root=gcc&view=rev
Cheers,
Janus
Index: gcc/fortran/expr.c
===
--- gcc/fortran/expr.c (Rev
Hi Andre,
sorry, didn't want to be impolite. I was just not aware that it makes
a big difference whether I attach the patch or post the link. Patch
below.
Cheers,
Janus
Index: gcc/fortran/class.c
===
--- gcc/fortran/class.c(Rev
Hi Janus,
may I ask you to attach also the "obvious" patches to the mail you send to the
list? It is far more comfortable to take a look at the patch in the mail than
open the webpage. Furthermore is it considered polite to attach the patches
even when they are obvious. This is not to treat you ba
Hi all,
I have committed to trunk another obvious patch to fix an ICE on invalid code:
https://gcc.gnu.org/viewcvs?rev=241993&root=gcc&view=rev
Cheers,
Janus
Hi all,
I have just committed as obvious a small patch for an ice-on-invalid problem:
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=241979
Cheers,
Janus
Am 07.11.2016 um 16:25 schrieb Thomas Koenig:
PR fortran/78826
... should have been PR 78226.
1 - 100 of 288 matches
Mail list logo
