Re: [Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks

2018-02-14 Thread Janus Weil
>>> Adding ! { dg-additional-options "-std=f2003" } >>> doesn't work, because the test uses >>> call abort > > I actually think we should get rid of such extensions in the > testsuite, where possible. This particular one is used all over the > place, but could be easily replaces by something like

Re: [Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks

2018-02-14 Thread Janus Weil
2018-02-14 12:47 GMT+01:00 Jakub Jelinek : > On Wed, Feb 14, 2018 at 12:30:14PM +0100, Jakub Jelinek wrote: >> On Tue, Feb 13, 2018 at 07:24:35PM +0100, Janus Weil wrote: >> > as the subject line says, the attached patch rejects procedure >> > pointers in COMMON blocks (which is forbidden in F08).

Re: [Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks

2018-02-14 Thread Jakub Jelinek
On Wed, Feb 14, 2018 at 12:30:14PM +0100, Jakub Jelinek wrote: > On Tue, Feb 13, 2018 at 07:24:35PM +0100, Janus Weil wrote: > > as the subject line says, the attached patch rejects procedure > > pointers in COMMON blocks (which is forbidden in F08). Since it's > > apparently legal in F03, I'm stil

Re: [Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks

2018-02-14 Thread Jakub Jelinek
On Tue, Feb 13, 2018 at 07:24:35PM +0100, Janus Weil wrote: > Hi all, > > as the subject line says, the attached patch rejects procedure > pointers in COMMON blocks (which is forbidden in F08). Since it's > apparently legal in F03, I'm still accepting it with -std=f2003 and > add that flag to a te

Re: [Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks

2018-02-13 Thread Janus Weil
2018-02-13 20:55 GMT+01:00 Richard Biener : > On February 13, 2018 8:14:33 PM GMT+01:00, Steve Kargl > wrote: >>On Tue, Feb 13, 2018 at 07:24:35PM +0100, Janus Weil wrote: >>> >>> As my last submission, this fixes fallout from >>> >>https://groups.google.com/forum/?fromgroups#!topic/comp.lang.for

Re: [Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks

2018-02-13 Thread Richard Biener
On February 13, 2018 8:14:33 PM GMT+01:00, Steve Kargl wrote: >On Tue, Feb 13, 2018 at 07:24:35PM +0100, Janus Weil wrote: >> >> As my last submission, this fixes fallout from >> >https://groups.google.com/forum/?fromgroups#!topic/comp.lang.fortran/AIHRQ2kJv3c. >> As the last one, it is a very s

Re: [Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks

2018-02-13 Thread Steve Kargl
On Tue, Feb 13, 2018 at 07:24:35PM +0100, Janus Weil wrote: > > As my last submission, this fixes fallout from > https://groups.google.com/forum/?fromgroups#!topic/comp.lang.fortran/AIHRQ2kJv3c. > As the last one, it is a very simple fix for an accepts-invalid > problem (which is not a regression)

[Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks

2018-02-13 Thread Janus Weil
Hi all, as the subject line says, the attached patch rejects procedure pointers in COMMON blocks (which is forbidden in F08). Since it's apparently legal in F03, I'm still accepting it with -std=f2003 and add that flag to a test case where this 'feature' is used. In another one, I'm adding the err