> >> The use of TAB there is fine. The issue is that you have trail
> white
> >> space at the end of the line, which is still present in the latest
> patch.
>
> Sorry. I confused it with spaces at the start of pattern instead of
> trailing space. I have modified it as per your suggestion.
> Pleas
On 27/02/13 11:16, Hurugalawadi, Naveen wrote:
Hi Marcus,
The use of TAB there is fine. The issue is that you have trail white
space at the end of the line, which is still present in the latest patch.
Sorry. I confused it with spaces at the start of pattern instead of
trailing space. I have
Hi Marcus,
>> The use of TAB there is fine. The issue is that you have trail white
>> space at the end of the line, which is still present in the latest patch.
Sorry. I confused it with spaces at the start of pattern instead of
trailing space. I have modified it as per your suggestion.
Please r
On 27/02/13 10:42, Hurugalawadi, Naveen wrote:
Hi Marcus,
I had a "TAB" inserted as the pattern was starting at the 9th column.
Hence, it showed trailing whites paces in the patch.
The use of TAB there is fine. The issue is that you have trail white
space at the end of the line, which is sti
ks,
Naveen
From: Marcus Shawcroft [marcus.shawcr...@arm.com]
Sent: Wednesday, February 27, 2013 3:32 PM
To: Hurugalawadi, Naveen
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Patch, AArch64] Implement SIMD Absolute Difference Instructions
On 27/02/13 05:15, Hurugalawa
On 27/02/13 05:15, Hurugalawadi, Naveen wrote:
The trailing white spaces are observed only in the patch. When the
patch is applied on sources, there are no trailing white spaces.
When I applied the patch to my dev tree it resulted in source with
trailing white space.
Please re-spin the patch
Hi Marcus,
Thanks for reviewing the patch and your comments.
>> Please drop the trailing white space, here and on the following
>> patterns.
The trailing white spaces are observed only in the patch. When the
patch is applied on sources, there are no trailing white spaces.
>> GNU style, spaces a
On 30/01/13 05:46, Hurugalawadi, Naveen wrote:
Hi,
Please find attached the patch that implements absolute difference
instructions for aarch64 target.
The patch modifies the testcase vect.c and vect-fp.c to check the
generated instructions and also their functionality.
Please review the patch a
Hi Naveen,
Please accept my apologies for the delay in responding to your patch.
On 30/01/13 05:46, Hurugalawadi, Naveen wrote:
+(define_insn "abd_3"
+ [(set (match_operand:VDQ_BHSI 0 "register_operand" "=w")
+ (abs:VDQ_BHSI (minus:VDQ_BHSI
Please drop the trailing white space, here
Hi,
Please consider this as a gentle reminder to review the patch
posted at following link:-
http://gcc.gnu.org/ml/gcc-patches/2013-01/msg01412.html
Please review the patch and let me know if its okay?
Thanks & Regards,
Naveen.H.S
Hi,
Please find attached the patch that implements absolute difference
instructions for aarch64 target.
The patch modifies the testcase vect.c and vect-fp.c to check the
generated instructions and also their functionality.
Please review the patch and let me know if there should be any
modificatio
11 matches
Mail list logo
