Re: [Patch, AArch64] Enable Address sanitizer and UB sanitizer

2014-10-24 Thread Andrew Pinski
On Fri, Oct 24, 2014 at 8:44 AM, Christophe Lyon wrote: > On 29 September 2014 15:01, Christophe Lyon > wrote: >> On 26 September 2014 23:05, Andreas Schwab wrote: >>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=34c65c4 >>> >>> * sanitizer_common/sanitizer

Re: [Patch, AArch64] Enable Address sanitizer and UB sanitizer

2014-10-24 Thread Christophe Lyon
On 29 September 2014 15:01, Christophe Lyon wrote: > On 26 September 2014 23:05, Andreas Schwab wrote: >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=34c65c4 >> >> * sanitizer_common/sanitizer_platform_limits_posix.h >> (__sanitizer___kernel_old_uid_

Re: [Patch, AArch64] Enable Address sanitizer and UB sanitizer

2014-09-29 Thread Christophe Lyon
On 26 September 2014 23:05, Andreas Schwab wrote: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=34c65c4 > > * sanitizer_common/sanitizer_platform_limits_posix.h > (__sanitizer___kernel_old_uid_t, __sanitizer___kernel_old_gid_t) > [__aarch64__]

Re: [Patch, AArch64] Enable Address sanitizer and UB sanitizer

2014-09-26 Thread Andreas Schwab
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=34c65c4 * sanitizer_common/sanitizer_platform_limits_posix.h (__sanitizer___kernel_old_uid_t, __sanitizer___kernel_old_gid_t) [__aarch64__]: Define to unsigned short. --- libsanitizer/sanitizer_com

Re: [Patch, AArch64] Enable Address sanitizer and UB sanitizer

2014-09-26 Thread Christophe Lyon
On 21 September 2014 20:07, Christophe Lyon wrote: > On 17 September 2014 12:48, Marcus Shawcroft > wrote: >> On 9 September 2014 13:08, Christophe Lyon >> wrote: >>> On 9 September 2014 12:03, wrote: > On Sep 9, 2014, at 2:50 AM, Marcus Shawcroft > wrote: > > +st

Re: [Patch, AArch64] Enable Address sanitizer and UB sanitizer

2014-09-21 Thread Christophe Lyon
On 17 September 2014 12:48, Marcus Shawcroft wrote: > On 9 September 2014 13:08, Christophe Lyon wrote: >> On 9 September 2014 12:03, wrote: >>> >>> On Sep 9, 2014, at 2:50 AM, Marcus Shawcroft wrote: +static unsigned HOST_WIDE_INT +aarch64_asan_shadow_offset (void) >

Re: [Patch, AArch64] Enable Address sanitizer and UB sanitizer

2014-09-17 Thread Marcus Shawcroft
On 9 September 2014 13:08, Christophe Lyon wrote: > On 9 September 2014 12:03, wrote: >> >> >>> On Sep 9, 2014, at 2:50 AM, Marcus Shawcroft >>> wrote: >>> >>> +static unsigned HOST_WIDE_INT >>> +aarch64_asan_shadow_offset (void) >>> +{ >>> + return (HOST_WIDE_INT_1 << 36); >>> +} >>> + >>> >

Re: [Patch, AArch64] Enable Address sanitizer and UB sanitizer

2014-09-09 Thread Christophe Lyon
On 9 September 2014 12:03, wrote: > > >> On Sep 9, 2014, at 2:50 AM, Marcus Shawcroft >> wrote: >> >> +static unsigned HOST_WIDE_INT >> +aarch64_asan_shadow_offset (void) >> +{ >> + return (HOST_WIDE_INT_1 << 36); >> +} >> + >> >> Looking around various other ports I see magic numbers includin

Re: [Patch, AArch64] Enable Address sanitizer and UB sanitizer

2014-09-09 Thread pinskia
> On Sep 9, 2014, at 2:50 AM, Marcus Shawcroft > wrote: > > +static unsigned HOST_WIDE_INT > +aarch64_asan_shadow_offset (void) > +{ > + return (HOST_WIDE_INT_1 << 36); > +} > + > > Looking around various other ports I see magic numbers including 29, > 41, 44 Help me understand why 36 is

Re: [Patch, AArch64] Enable Address sanitizer and UB sanitizer

2014-09-09 Thread Marcus Shawcroft
+static unsigned HOST_WIDE_INT +aarch64_asan_shadow_offset (void) +{ + return (HOST_WIDE_INT_1 << 36); +} + Looking around various other ports I see magic numbers including 29, 41, 44 Help me understand why 36 is the right choice for aarch64? Cheers /Marcus On 5 September 2014 15:49, Chris

[Patch, AArch64] Enable Address sanitizer and UB sanitizer

2014-09-05 Thread Christophe Lyon
Hi, The attached patch enables the address and undefined behavior sanitizers. I have tested it on AArch64 hardware, and asan.exp tests pass, but a few ubsan.exp tests fail as follows: FAIL: c-c++-common/ubsan/float-cast-overflow-1.c -O3 -g execution test FAIL: c-c++-common/ubsan/float-cast-ove