Re: [PR90916] ICE in retrieve specialization

2020-01-15 Thread Nathan Sidwell
On 1/14/20 4:21 PM, Marek Polacek wrote: On Tue, Jan 14, 2020 at 04:10:07PM -0500, Nathan Sidwell wrote: 2020-01-14 Nathan Sidwell + PT c++/90916 Note this has PT instead of PR :). yeah, I caught the typo on the followup. Thanks for noticing! nathan -- Nathan Sidwell

Re: [PR90916] ICE in retrieve specialization

2020-01-14 Thread Marek Polacek
On Tue, Jan 14, 2020 at 04:10:07PM -0500, Nathan Sidwell wrote: > On 1/14/20 3:29 PM, Nathan Sidwell wrote: > > On 1/14/20 3:13 PM, Jason Merrill wrote: > > > On 1/14/20 2:14 PM, Nathan Sidwell wrote: > > > > +  if (tree ti = (TREE_CODE (fn) == TYPE_DECL && > > > > !TYPE_DECL_ALIAS_P (fn) > > >

Re: [PR90916] ICE in retrieve specialization

2020-01-14 Thread Nathan Sidwell
On 1/14/20 3:29 PM, Nathan Sidwell wrote: On 1/14/20 3:13 PM, Jason Merrill wrote: On 1/14/20 2:14 PM, Nathan Sidwell wrote: +  if (tree ti = (TREE_CODE (fn) == TYPE_DECL && !TYPE_DECL_ALIAS_P (fn) + ? TYPE_TEMPLATE_INFO (TREE_TYPE (fn)) + : DECL_TEMPLATE_INFO (fn))

Re: [PR90916] ICE in retrieve specialization

2020-01-14 Thread Nathan Sidwell
On 1/14/20 3:13 PM, Jason Merrill wrote: On 1/14/20 2:14 PM, Nathan Sidwell wrote: +  if (tree ti = (TREE_CODE (fn) == TYPE_DECL && !TYPE_DECL_ALIAS_P (fn) + ? TYPE_TEMPLATE_INFO (TREE_TYPE (fn)) + : DECL_TEMPLATE_INFO (fn))) Is there a reason not to use get_templa

Re: [PR90916] ICE in retrieve specialization

2020-01-14 Thread Jason Merrill
On 1/14/20 2:14 PM, Nathan Sidwell wrote: + if (tree ti = (TREE_CODE (fn) == TYPE_DECL && !TYPE_DECL_ALIAS_P (fn) +? TYPE_TEMPLATE_INFO (TREE_TYPE (fn)) +: DECL_TEMPLATE_INFO (fn))) Is there a reason not to use get_template_info? Jason

[PR90916] ICE in retrieve specialization

2020-01-14 Thread Nathan Sidwell
This fixes an ICE caused by a cleanup of get_class_binding. Previously its type_or_fn parm defaulted to -1, which had some funky behaviour I convinced myself was irrelevant to C++ source. Here we're peeking behind the curtain of a class under construction, and previously the -1 behaviour caus