Re: [PR83370][AARCH64]Use tighter register constraints for sibcall patterns.

2018-02-01 Thread James Greenhalgh
On Thu, Feb 01, 2018 at 02:43:17PM +, Renlin Li wrote: > Hi James, > > Thanks for the review! I committed it on trunk. > > Is it Okay to backport this patch to release branch 5, 6,7? > It applies cleanly without any logic changes. 6 and 7 yes, OK. 5 is no longer supported so may be a waste

Re: [PR83370][AARCH64]Use tighter register constraints for sibcall patterns.

2018-02-01 Thread Renlin Li
Hi James, Thanks for the review! I committed it on trunk. Is it Okay to backport this patch to release branch 5, 6,7? It applies cleanly without any logic changes. Regards, Renlin On 31/01/18 17:56, James Greenhalgh wrote: On Tue, Jan 30, 2018 at 03:45:17PM +, Renlin Li wrote: Hi Richard

Re: [PR83370][AARCH64]Use tighter register constraints for sibcall patterns.

2018-01-31 Thread James Greenhalgh
On Tue, Jan 30, 2018 at 03:45:17PM +, Renlin Li wrote: > Hi Richard, > > Thanks for the review! > > On 29/01/18 20:23, Richard Sandiford wrote: > > > > The patch looks good to me FWIW. How about adding something like > > the following testcase? > > > >

Re: [PR83370][AARCH64]Use tighter register constraints for sibcall patterns.

2018-01-30 Thread Renlin Li
Hi Richard, Thanks for the review! On 29/01/18 20:23, Richard Sandiford wrote: The patch looks good to me FWIW. How about adding something like the following testcase? /* { dg-do run } */ /* { dg-options "-O2" } */ typedef void (*fun) (void); void __att

Re: [PR83370][AARCH64]Use tighter register constraints for sibcall patterns.

2018-01-29 Thread Richard Sandiford
Renlin Li writes: > Hi all, > > In aarch64 backend, ip0/ip1 register will be used in the prologue/epilogue as > temporary register. > > When the compiler is performing sibcall optimization. It has the chance to use > ip0/ip1 register for indirect function call to hold the address. However, > thos

Re: [PR83370][AARCH64]Use tighter register constraints for sibcall patterns.

2017-12-20 Thread Renlin Li
Ping ~ On 11/12/17 15:27, Renlin Li wrote: Hi all, In aarch64 backend, ip0/ip1 register will be used in the prologue/epilogue as temporary register. When the compiler is performing sibcall optimization. It has the chance to use ip0/ip1 register for indirect function call to hold the address. H

[PR83370][AARCH64]Use tighter register constraints for sibcall patterns.

2017-12-11 Thread Renlin Li
Hi all, In aarch64 backend, ip0/ip1 register will be used in the prologue/epilogue as temporary register. When the compiler is performing sibcall optimization. It has the chance to use ip0/ip1 register for indirect function call to hold the address. However, those two register might be clobbere