Re: [PR68432 04/22] Remove global which_alternative

2015-11-25 Thread Richard Sandiford
Bernd Schmidt writes: > On 11/25/2015 05:19 PM, Richard Sandiford wrote: >> I guess not, but without it we have both local and global variables >> called which_alternative. > > So call the local ones something else (alt_to_check, requested_alt or > attr_alt)? Well, having two names for the same

Re: [PR68432 04/22] Remove global which_alternative

2015-11-25 Thread Bernd Schmidt
On 11/25/2015 05:19 PM, Richard Sandiford wrote: I guess not, but without it we have both local and global variables called which_alternative. So call the local ones something else (alt_to_check, requested_alt or attr_alt)? Bernd

Re: [PR68432 04/22] Remove global which_alternative

2015-11-25 Thread Richard Sandiford
Bernd Schmidt writes: > On 11/25/2015 01:26 PM, Richard Sandiford wrote: >> Later patches in the series add a new form of attribute that takes the >> attribute number as an argument, rather than it being stored in the >> global which_alternative variable. >> >> Having both a local alternative numb

Re: [PR68432 04/22] Remove global which_alternative

2015-11-25 Thread Bernd Schmidt
On 11/25/2015 01:26 PM, Richard Sandiford wrote: Later patches in the series add a new form of attribute that takes the attribute number as an argument, rather than it being stored in the global which_alternative variable. Having both a local alternative number and a global alternative number is

[PR68432 04/22] Remove global which_alternative

2015-11-25 Thread Richard Sandiford
Later patches in the series add a new form of attribute that takes the attribute number as an argument, rather than it being stored in the global which_alternative variable. Having both a local alternative number and a global alternative number is likely to cause confusion. This patch therefore g