Re: [PR68083] stop ifcombine from moving uninitialized uses before their guards

2015-11-02 Thread Richard Biener
On Fri, Oct 30, 2015 at 7:02 PM, Alexandre Oliva wrote: > On Oct 30, 2015, Alexandre Oliva wrote: > >> Incidentally, bb_no_side_effects_p (inner_cond_bb) is called in all four >> tests in tree_ssa_ifcombine_bb_1, for each outer_cond_bb that >> tree_ssa_ifcombine_bb might choose. Is there any rea

Re: [PR68083] stop ifcombine from moving uninitialized uses before their guards

2015-11-02 Thread Richard Biener
On Fri, Oct 30, 2015 at 2:41 PM, Alexandre Oliva wrote: > The ifcombine pass may move a conditional access to an uninitialized > value before the condition that ensures it is always well-defined, > thus introducing undefined behavior. Stop it from doing so. > > Regstrapped on x86_64-linux-gnu and

Re: [PR68083] stop ifcombine from moving uninitialized uses before their guards

2015-10-30 Thread Alexandre Oliva
On Oct 30, 2015, Alexandre Oliva wrote: > Incidentally, bb_no_side_effects_p (inner_cond_bb) is called in all four > tests in tree_ssa_ifcombine_bb_1, for each outer_cond_bb that > tree_ssa_ifcombine_bb might choose. Is there any reason to not factor > it out to the test that checks whether the

[PR68083] stop ifcombine from moving uninitialized uses before their guards

2015-10-30 Thread Alexandre Oliva
The ifcombine pass may move a conditional access to an uninitialized value before the condition that ensures it is always well-defined, thus introducing undefined behavior. Stop it from doing so. Regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok to install? Incidentally, bb_no_side_effect