Re: [PR67335] drop dummy zero from reverse VTA ops, fix infinite recursion

2015-12-02 Thread Jeff Law
On 11/26/2015 04:45 PM, Alexandre Oliva wrote: VTA's cselib expression hashing compares expressions with the same hash before adding them to the hash table. When there is a collision involving a self-referencing expression, we could get infinite recursion, in spite of the cycle breakers already

Re: [PR67335] drop dummy zero from reverse VTA ops, fix infinite recursion

2015-11-27 Thread Alexandre Oliva
On Nov 27, 2015, Jakub Jelinek wrote: > I'm sorry, but I don't remember. Perhaps it has been before some recursion > prevention has been added or whatever, maybe your own PR52001? Yeah. Thanks anyway. > Have you checked if your patch results in any significant debug info quality > changes It

Re: [PR67335] drop dummy zero from reverse VTA ops, fix infinite recursion

2015-11-27 Thread Jakub Jelinek
On Thu, Nov 26, 2015 at 09:45:06PM -0200, Alexandre Oliva wrote: > VTA's cselib expression hashing compares expressions with the same > hash before adding them to the hash table. When there is a collision > involving a self-referencing expression, we could get infinite > recursion, in spite of the

Re: [PR67335] drop dummy zero from reverse VTA ops, fix infinite recursion

2015-11-26 Thread Alexandre Oliva
On Nov 26, 2015, Alexandre Oliva wrote: > for gcc/ChangeLog > PR debug/67355 > * var-tracking.c (reverse_op): Don't add dummy zero to reverse > ops that simplify back to the original value. > * alias.c (refs_newer_value_p): Cut off recursion for > expressions conta

[PR67335] drop dummy zero from reverse VTA ops, fix infinite recursion

2015-11-26 Thread Alexandre Oliva
VTA's cselib expression hashing compares expressions with the same hash before adding them to the hash table. When there is a collision involving a self-referencing expression, we could get infinite recursion, in spite of the cycle breakers already in place. The problem is currently latent in the