Re: [PR middle-end/55398] Convert vec<> into a POD

2012-11-20 Thread Ulrich Weigand
Diego Novillo wrote: > On Tue, Nov 20, 2012 at 11:23 AM, Diego Novillo wrote: > > > 2012-11-20 Diego Novillo > > > > PR middle-end/55398 > > * vec.h (class vec_prefix): Make every field public. > > Rename field alloc_ to alloc_PRIVATE_. > > Rename field num_ to num_PRIVATE_. >

Re: [PR middle-end/55398] Convert vec<> into a POD

2012-11-20 Thread Diego Novillo
On Tue, Nov 20, 2012 at 2:35 PM, Jakub Jelinek wrote: > 2012-11-20 Jakub Jelinek > > * vec.h (class vec_prefix): Change into struct. > Rename field alloc_PRIVATE_ back to alloc_. > Rename field num_PRIVATE_ to num_. > Update all users. > (class vec): Ren

Re: [PR middle-end/55398] Convert vec<> into a POD

2012-11-20 Thread Jakub Jelinek
On Tue, Nov 20, 2012 at 11:27:06AM -0500, Diego Novillo wrote: > On Tue, Nov 20, 2012 at 11:23 AM, Diego Novillo wrote: > > > 2012-11-20 Diego Novillo > > > > PR middle-end/55398 > > * vec.h (class vec_prefix): Make every field public. > > Rename field alloc_ to alloc_PRIVATE_. > >

Re: [PR middle-end/55398] Convert vec<> into a POD

2012-11-20 Thread Andreas Tobler
On 20.11.12 17:27, Diego Novillo wrote: > On Tue, Nov 20, 2012 at 11:23 AM, Diego Novillo wrote: > >> 2012-11-20 Diego Novillo >> >> PR middle-end/55398 >> * vec.h (class vec_prefix): Make every field public. >> Rename field alloc_ to alloc_PRIVATE_. >> Rename field num_ to num

Re: [PR middle-end/55398] Convert vec<> into a POD

2012-11-20 Thread Diego Novillo
On Tue, Nov 20, 2012 at 11:23 AM, Diego Novillo wrote: > 2012-11-20 Diego Novillo > > PR middle-end/55398 > * vec.h (class vec_prefix): Make every field public. > Rename field alloc_ to alloc_PRIVATE_. > Rename field num_ to num_PRIVATE_. > Update all users. > (class ve

[PR middle-end/55398] Convert vec<> into a POD

2012-11-20 Thread Diego Novillo
This fixes PR 55398 by making vec<> a true POD. I thought we could get away with having private fields, but we can't. We fail to pass vec<> instances through varargs. The patch makes every field public and mangles the field names in the hope that no future patch will try to make use of them dire