Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-18 Thread Alexandre Oliva
On Jan 16, 2013, Jan Hubicka wrote: > For 2) the symtab_get_node test seems resonable to me. It is what > dwarf2out does, too. We keep nodes for external vars that are > refereed but we remove all optimized out nodes. Since you agreed this was the right approach and richi said he didn't care m

Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-16 Thread Richard Biener
On Wed, Jan 16, 2013 at 2:17 PM, Alexandre Oliva wrote: > On Jan 16, 2013, Jan Hubicka wrote: > >> 2) has the obvious advantage that unused vars are not going to be output just >> for sake of checking code. For 2) the symtab_get_node test seems resonable >> to >> me. > > That's what I first imp

Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-16 Thread Alexandre Oliva
On Jan 16, 2013, Jan Hubicka wrote: > 2) has the obvious advantage that unused vars are not going to be output just > for sake of checking code. For 2) the symtab_get_node test seems resonable to > me. That's what I first implemented, and I still firmly believe symtab_get_node is the correct te

Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-16 Thread Jan Hubicka
> No, the bug is that we're registering something because at an earlier > point (when we emitted checks) there were references to it. The > references were all optimized away, we correctly decided (elsewhere) the > object was not referenced, and we removed it from the symbol table, but > mudflap s

Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-16 Thread Alexandre Oliva
On Jan 7, 2013, Richard Biener wrote: > On Sun, Jan 6, 2013 at 8:47 PM, Alexandre Oliva wrote: >> On Jan 2, 2013, Richard Biener wrote: >> >>> On Sun, Dec 30, 2012 at 1:22 AM, Alexandre Oliva wrote: On Dec 21, 2012, Richard Biener wrote: > On Fri, Dec 21, 2012 at 6:33 AM, Al

Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-07 Thread Richard Biener
On Sun, Jan 6, 2013 at 8:47 PM, Alexandre Oliva wrote: > On Jan 2, 2013, Richard Biener wrote: > >> On Sun, Dec 30, 2012 at 1:22 AM, Alexandre Oliva wrote: >>> On Dec 21, 2012, Richard Biener wrote: >>> On Fri, Dec 21, 2012 at 6:33 AM, Alexandre Oliva wrote: > libmudflap emits a glob

Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-06 Thread Alexandre Oliva
On Jan 2, 2013, Richard Biener wrote: > On Sun, Dec 30, 2012 at 1:22 AM, Alexandre Oliva wrote: >> On Dec 21, 2012, Richard Biener wrote: >> >>> On Fri, Dec 21, 2012 at 6:33 AM, Alexandre Oliva wrote: libmudflap emits a global initializer that registers memory ranges for global dat

Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-02 Thread Richard Biener
On Sun, Dec 30, 2012 at 1:22 AM, Alexandre Oliva wrote: > On Dec 21, 2012, Richard Biener wrote: > >> On Fri, Dec 21, 2012 at 6:33 AM, Alexandre Oliva wrote: >>> libmudflap emits a global initializer that registers memory ranges for >>> global data symbols. However, even if IPA decides not to e

Re: [PR libmudflap/53359] don't register symbols not emitted

2012-12-29 Thread Alexandre Oliva
On Dec 21, 2012, Richard Biener wrote: > On Fri, Dec 21, 2012 at 6:33 AM, Alexandre Oliva wrote: >> libmudflap emits a global initializer that registers memory ranges for >> global data symbols. However, even if IPA decides not to emit a symbol >> because it's unused, we'd still emit registrati

Re: [PR libmudflap/53359] don't register symbols not emitted

2012-12-21 Thread Jan Hubicka
> On Fri, Dec 21, 2012 at 10:50:58AM +0100, Richard Biener wrote: > > On Fri, Dec 21, 2012 at 6:33 AM, Alexandre Oliva wrote: > > > libmudflap emits a global initializer that registers memory ranges for > > > global data symbols. However, even if IPA decides not to emit a symbol > > > because it'

Re: [PR libmudflap/53359] don't register symbols not emitted

2012-12-21 Thread Jakub Jelinek
On Fri, Dec 21, 2012 at 10:50:58AM +0100, Richard Biener wrote: > On Fri, Dec 21, 2012 at 6:33 AM, Alexandre Oliva wrote: > > libmudflap emits a global initializer that registers memory ranges for > > global data symbols. However, even if IPA decides not to emit a symbol > > because it's unused,

Re: [PR libmudflap/53359] don't register symbols not emitted

2012-12-21 Thread Richard Biener
On Fri, Dec 21, 2012 at 6:33 AM, Alexandre Oliva wrote: > libmudflap emits a global initializer that registers memory ranges for > global data symbols. However, even if IPA decides not to emit a symbol > because it's unused, we'd still emit registration sequences for them in > some cases, which,

[PR libmudflap/53359] don't register symbols not emitted

2012-12-20 Thread Alexandre Oliva
libmudflap emits a global initializer that registers memory ranges for global data symbols. However, even if IPA decides not to emit a symbol because it's unused, we'd still emit registration sequences for them in some cases, which, in the PR testcase, would result in TOC references to the undefin