Re: [PING v2][PATCH] Make function clone name numbering independent.

2018-12-04 Thread Michael Ploujnikov
On 2018-12-04 7:48 a.m., Martin Jambor wrote: > Hi, > > On Tue, Sep 04 2018, Michael Ploujnikov wrote: >> >> I've tried building with numbered_clone_function_name replaced by >> suffixed_function_name and with --enable-offload-targets=hsa and >> didn't see any errors in gomp.exp. I don't have a re

Re: [PING v2][PATCH] Make function clone name numbering independent.

2018-12-04 Thread Martin Jambor
Hi, On Tue, Sep 04 2018, Michael Ploujnikov wrote: > > I've tried building with numbered_clone_function_name replaced by > suffixed_function_name and with --enable-offload-targets=hsa and > didn't see any errors in gomp.exp. I don't have a readily available > HSA setup so if you could do a quick t

Re: [PING v2][PATCH] Make function clone name numbering independent.

2018-09-04 Thread Michael Ploujnikov
Hi Martin, On 2018-09-03 06:01 AM, Martin Jambor wrote: > Hi, > > On Fri, Aug 31 2018, Michael Ploujnikov wrote: >> I've done some more digging into the current uses of >> numbered_clone_function_name and checked if any tests fail if I change >> it to suffixed_function_name: >> >> - gcc/cgraphc

Re: [PING v2][PATCH] Make function clone name numbering independent.

2018-09-04 Thread Michael Ploujnikov
Hi Martin, Richard, Thanks for your responses. On 2018-09-03 09:15 AM, Martin Jambor wrote: > Hi, > > On Mon, Sep 03 2018, Richard Biener wrote: >> On Mon, Sep 3, 2018 at 12:02 PM Martin Jambor wrote: >>> >>> Hi, >>> >>> On Fri, Aug 31 2018, Michael Ploujnikov wrote: I've done some more di

Re: [PING v2][PATCH] Make function clone name numbering independent.

2018-09-03 Thread Martin Jambor
Hi, On Mon, Sep 03 2018, Richard Biener wrote: > On Mon, Sep 3, 2018 at 12:02 PM Martin Jambor wrote: >> >> Hi, >> >> On Fri, Aug 31 2018, Michael Ploujnikov wrote: >> > I've done some more digging into the current uses of >> > numbered_clone_function_name and checked if any tests fail if I chang

Re: [PING v2][PATCH] Make function clone name numbering independent.

2018-09-03 Thread Richard Biener
On Mon, Sep 3, 2018 at 12:02 PM Martin Jambor wrote: > > Hi, > > On Fri, Aug 31 2018, Michael Ploujnikov wrote: > > I've done some more digging into the current uses of > > numbered_clone_function_name and checked if any tests fail if I change > > it to suffixed_function_name: > > > > - gcc/cgra

Re: [PING v2][PATCH] Make function clone name numbering independent.

2018-09-03 Thread Martin Jambor
Hi, On Fri, Aug 31 2018, Michael Ploujnikov wrote: > I've done some more digging into the current uses of > numbered_clone_function_name and checked if any tests fail if I change > it to suffixed_function_name: > > - gcc/cgraphclones.c: DECL_NAME (new_decl) = numbered_clone_function_name > (th

Re: [PING v2][PATCH] Make function clone name numbering independent.

2018-08-31 Thread Michael Ploujnikov
On 2018-08-13 07:58 PM, Michael Ploujnikov wrote: > Ping and I've updated the patch since last time as follows: > > - unittest scans assembly rather than the constprop dump because its > forward changed > - unittests should handle different hosts where any of > NO_DOT_IN_LABEL, NO_DOLL