Re: [PING] PR middle-end/95126: Expand small const structs as immediate constants

2022-06-06 Thread Rainer Orth
Hi Roger, >> I just tried this on i386-pc-solaris2.11: unfortunately, it made no > difference. > > Awesome! Very many thanks for trying this. Alas it confirms that the patch > I'm currently spinning won't have any affect. So by a process of > elimination, > the miscompilation must be triggered

RE: [PING] PR middle-end/95126: Expand small const structs as immediate constants

2022-06-06 Thread Roger Sayle
Hi Rainer, > > The one experiment I'd like to be able to try, to investigate the > > cause/cure of this, is: > > > > diff --git a/gcc/calls.cc b/gcc/calls.cc index a4336c1..05fdd24 100644 > > --- a/gcc/calls.cc > > +++ b/gcc/calls.cc > > @@ -2177,7 +2177,7 @@ load_register_parameters (struct arg

Re: [PING] PR middle-end/95126: Expand small const structs as immediate constants

2022-06-06 Thread Rainer Orth
Andreas Schwab writes: > On Jun 06 2022, Roger Sayle wrote: > >> gcc -std=gnu99 -c -g -gnatpg -gnatwns -gnata -W -Wall -I- -I. >> -Iada/generated -Iada -I../../gcc/gcc/ada ../../gcc/gcc/ada/osint.adb -o >> ada/osint.o >> osint.adb:438:31: "strlen" not declared in "CRTL" >> osint.adb:441:14: "str

Re: [PING] PR middle-end/95126: Expand small const structs as immediate constants

2022-06-06 Thread Rainer Orth
Hi Roger, > My sincere apologies for the breakage. I'm currently regression testing a > solution to the ICEs introduced by my "small const struct" patch, which > fingers-crossed might also fix this Ada bootstrap. For a while when > Rainer also reported the bootstrap failure is visible, on > x86_

Re: [PING] PR middle-end/95126: Expand small const structs as immediate constants

2022-06-06 Thread Andreas Schwab
On Jun 06 2022, Roger Sayle wrote: > Hi Andreas, >> > gcc -std=gnu99 -c -g -gnatpg -gnatwns -gnata -W -Wall -I- -I. >> > -Iada/generated -Iada -I../../gcc/gcc/ada ../../gcc/gcc/ada/osint.adb >> > -o ada/osint.o >> > osint.adb:438:31: "strlen" not declared in "CRTL" >> > osint.adb:441:14: "strncp

RE: [PING] PR middle-end/95126: Expand small const structs as immediate constants

2022-06-06 Thread Roger Sayle
Hi Andreas, > > gcc -std=gnu99 -c -g -gnatpg -gnatwns -gnata -W -Wall -I- -I. > > -Iada/generated -Iada -I../../gcc/gcc/ada ../../gcc/gcc/ada/osint.adb > > -o ada/osint.o > > osint.adb:438:31: "strlen" not declared in "CRTL" > > osint.adb:441:14: "strncpy" not declared in "CRTL" > > osint.adb:6

Re: [PING] PR middle-end/95126: Expand small const structs as immediate constants

2022-06-06 Thread Andreas Schwab
On Jun 06 2022, Roger Sayle wrote: > gcc -std=gnu99 -c -g -gnatpg -gnatwns -gnata -W -Wall -I- -I. > -Iada/generated -Iada -I../../gcc/gcc/ada ../../gcc/gcc/ada/osint.adb -o > ada/osint.o > osint.adb:438:31: "strlen" not declared in "CRTL" > osint.adb:441:14: "strncpy" not declared in "CRTL" > os

RE: [PING] PR middle-end/95126: Expand small const structs as immediate constants

2022-06-06 Thread Roger Sayle
akage. Hopefully the fix I'm testing will cure this as well (but an ICE is different symptom to a silent miscompilation). Sorry again, Roger -- > -Original Message- > From: Rainer Orth > Sent: 05 June 2022 21:31 > To: Andreas Schwab > Cc: Roger Sayle ; gcc-patches@gc

Re: [PING] PR middle-end/95126: Expand small const structs as immediate constants

2022-06-05 Thread Rainer Orth
Andreas Schwab writes: > This breaks Ada on aarch64 in stage3, probably a miscompiled stage2 > compiler. For example: > > /opt/gcc/gcc-20220605/Build/./prev-gcc/xgcc > -B/opt/gcc/gcc-20220605/Build/./prev-gcc/ -B/usr/aarch64-suse-linux/bin/ > -B/usr/aarch64-suse-linux/bin/ -B/usr/aarch64-suse-li

Re: [PING] PR middle-end/95126: Expand small const structs as immediate constants

2022-06-05 Thread Andreas Schwab
This breaks Ada on aarch64 in stage3, probably a miscompiled stage2 compiler. For example: /opt/gcc/gcc-20220605/Build/./prev-gcc/xgcc -B/opt/gcc/gcc-20220605/Build/./prev-gcc/ -B/usr/aarch64-suse-linux/bin/ -B/usr/aarch64-suse-linux/bin/ -B/usr/aarch64-suse-linux/lib/ -isystem /usr/aarch64-su

[PING] PR middle-end/95126: Expand small const structs as immediate constants

2022-05-21 Thread Roger Sayle
I'd like to ping my patch for PR middle-end/95126 from February: https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590949.html As a regression fix, this has missed GCC 12, but hopefully its suitable for 13 now we're back in stage1. The patch has been refreshed and retested against gcc 13 tr