Re: [PING][PATCH 2/3] retire mem_signal_fence pattern

2017-09-05 Thread Christophe Lyon
Hi, On 5 September 2017 at 13:40, Uros Bizjak wrote: > On Tue, Sep 5, 2017 at 12:28 PM, Alexander Monakov wrote: >> On Mon, 4 Sep 2017, Uros Bizjak wrote: >>> introduced a couple of regressions on x86 (-m32, 32bit) testsuite: >>> >>> New failures: >>> FAIL: gcc.target/i386/pr71245-1.c scan-asse

Re: [PING][PATCH 2/3] retire mem_signal_fence pattern

2017-09-05 Thread Uros Bizjak
On Tue, Sep 5, 2017 at 12:28 PM, Alexander Monakov wrote: > On Mon, 4 Sep 2017, Uros Bizjak wrote: >> introduced a couple of regressions on x86 (-m32, 32bit) testsuite: >> >> New failures: >> FAIL: gcc.target/i386/pr71245-1.c scan-assembler-not (fistp|fild) >> FAIL: gcc.target/i386/pr71245-2.c sc

Re: [PING][PATCH 2/3] retire mem_signal_fence pattern

2017-09-05 Thread Uros Bizjak
On Tue, Sep 5, 2017 at 12:28 PM, Alexander Monakov wrote: > On Mon, 4 Sep 2017, Uros Bizjak wrote: >> introduced a couple of regressions on x86 (-m32, 32bit) testsuite: >> >> New failures: >> FAIL: gcc.target/i386/pr71245-1.c scan-assembler-not (fistp|fild) >> FAIL: gcc.target/i386/pr71245-2.c sc

Re: [PING][PATCH 2/3] retire mem_signal_fence pattern

2017-09-05 Thread Alexander Monakov
On Mon, 4 Sep 2017, Uros Bizjak wrote: > introduced a couple of regressions on x86 (-m32, 32bit) testsuite: > > New failures: > FAIL: gcc.target/i386/pr71245-1.c scan-assembler-not (fistp|fild) > FAIL: gcc.target/i386/pr71245-2.c scan-assembler-not movlps Sorry. I suggest that the tests be XFAI

Re: [PING][PATCH 2/3] retire mem_signal_fence pattern

2017-09-04 Thread Uros Bizjak
> On 09/01/2017 12:26 AM, Alexander Monakov wrote: >> On Thu, 31 Aug 2017, Jeff Law wrote: >>> This is OK. >>> >>> What's the point of the delete_insns_since calls in patch #3? >> >> Deleting the first barrier when maybe_expand_insn failed. >> Other functions in the file use a similar approach. > T

Re: [PING][PATCH 2/3] retire mem_signal_fence pattern

2017-09-03 Thread Jeff Law
On 09/01/2017 12:26 AM, Alexander Monakov wrote: > On Thu, 31 Aug 2017, Jeff Law wrote: >> This is OK. >> >> What's the point of the delete_insns_since calls in patch #3? > > Deleting the first barrier when maybe_expand_insn failed. > Other functions in the file use a similar approach. Thanks for

Re: [PING][PATCH 2/3] retire mem_signal_fence pattern

2017-08-31 Thread Alexander Monakov
On Thu, 31 Aug 2017, Jeff Law wrote: > This is OK. > > What's the point of the delete_insns_since calls in patch #3? Deleting the first barrier when maybe_expand_insn failed. Other functions in the file use a similar approach. Thanks. Alexander

Re: [PING][PATCH 2/3] retire mem_signal_fence pattern

2017-08-31 Thread Jeff Law
On 08/28/2017 06:05 AM, Alexander Monakov wrote: > Ping (for this and patch 3/3 in the thread). > > On Wed, 2 Aug 2017, Alexander Monakov wrote: > >> Similar to mem_thread_fence issue from the patch 1/3, RTL representation of >> __atomic_signal_fence must be a compiler barrier. We have just one

[PING][PATCH 2/3] retire mem_signal_fence pattern

2017-08-28 Thread Alexander Monakov
Ping (for this and patch 3/3 in the thread). On Wed, 2 Aug 2017, Alexander Monakov wrote: > Similar to mem_thread_fence issue from the patch 1/3, RTL representation of > __atomic_signal_fence must be a compiler barrier. We have just one backend > offering this pattern, and it does not place a co