Re: [PATCHv3 2/2] libstdc++: Add std::aligned_union.

2014-06-02 Thread Jonathan Wakely
On 16/04/14 17:47 +0200, Rüdiger Sonderfeld wrote: Of course I forgot to replace one _M_ instance. This should work now. Sorry about this. -- 8< - >8 -- C++11: [meta.trans.other] * libstdc++-v3/testsuite/20_util/aligned_union/1.cc: New f

Re: [PATCHv3 2/2] libstdc++: Add std::aligned_union.

2014-04-16 Thread Paolo Carlini
.. also, per the GNU conventions, ? of a conditional expression should be at the beginning of a line (not at the end of the previous one). Paolo.

Re: [PATCHv3 2/2] libstdc++: Add std::aligned_union.

2014-04-16 Thread Paolo Carlini
Hi, On 04/16/2014 05:47 PM, Rüdiger Sonderfeld wrote: + template Please avoid _ + Uppercase, those are badnames for many targets. Normally we add a p at the end. Also, I would mention in a comment the front-end bug preventing a much more straightforward implementation. Thanks, Paolo.

[PATCHv3 2/2] libstdc++: Add std::aligned_union.

2014-04-16 Thread Rüdiger Sonderfeld
Of course I forgot to replace one _M_ instance. This should work now. Sorry about this. -- 8< - >8 -- C++11: [meta.trans.other] * libstdc++-v3/testsuite/20_util/aligned_union/1.cc: New file. * libstdc++-v3/include/std/type_traits (__strict